Skip to content

PCI: dwc: Add support for 64-bit MSI target addresses

Will McVicker linux-pci lkml 6 versions – Applied

Status from this message: Applied to pci/dwc, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest2 patches 9 repliesApplied
  2. v52 patches 23 repliesSuperseded
  3. v42 patches 6 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v32 patches2 repliesSuperseded
v22 patches3 repliesSuperseded
v12 patches4 repliesSuperseded

Changes in v6 from the cover letter

* Retrying DMA allocation with 64-bit mask within the error if-statement.
* Use an int for the DMA mask instead of a bool and ternary operation.

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/2PCI: dwc: Drop dependency on ZONE_DMA32drivers/pci/controller/dwc/pcie-designware-host.c drivers/pci/controller/dwc/pcie-designware.h+7 -220 replies
2/2PCI: dwc: Add support for 64-bit MSI target addressdrivers/pci/controller/dwc/pcie-designware-host.c drivers/pci/controller/dwc/pcie-designware.c drivers/pci/controller/dwc/pcie-designware.h+25 -30 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJingoo HanRob Herring
1/2A-b R-b
2/2A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/2] PCI: dwc: Add support for 64-bit MSI target addresses

Hi All,

I've update patch 2/2 to address Robin's suggestions. This includes:

* Dropping the while-loop for retrying with a 64-bit mask in favor of retrying within the error if-statement.
* Using an int for the DMA mask instead of a bool and ternary operation.

Thanks again for the reviews and sorry for the extra revision today! Hopefully this is the last one :) If not, I'd be fine to submit patch 1/2 without 2/2 to avoid resending patch 1/2 for future revisions of patch 2/2 (unless I don't need to do that anyway).

Thanks,
Will

Will McVicker (2):
PCI: dwc: Drop dependency on ZONE_DMA32

v6:
* Retrying DMA allocation with 64-bit mask within the error if-statement.
* Use an int for the DMA mask instead of a bool and ternary operation.

v5:
* Updated patch 2/2 to first try with a 32-bit DMA mask. On failure, retry with a 64-bit mask if supported.

v4:
* Updated commit descriptions.
* Renamed msi_64b -> msi_64bit.
* Dropped msi_64bit ternary use.
* Dropped export of dw_pcie_msi_capabilities.

v3:
* Switched to a managed DMA allocation.
* Simplified the DMA allocation cleanup.
* Dropped msi_page from struct dw_pcie_rp.
* Allocating a u64 instead of a full page.

v2:
* Fixed build error caught by kernel test robot
* Fixed error handling reported by Isaac Manjarres
PCI: dwc: Add support for 64-bit MSI target address

 .../pci/controller/dwc/pcie-designware-host.c | 43 +++++++++----------
 drivers/pci/controller/dwc/pcie-designware.c  |  8 ++++
 drivers/pci/controller/dwc/pcie-designware.h  |  2 +-
 3 files changed, 30 insertions(+), 23 deletions(-)

base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868

Signature · 1 line
2.37.2.672.g94769d06f0-goog