Skip to content

--optimize fixes

Pablo Neira Ayuso netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2optimize: merging concatenation is unsupportedsrc/optimize.c tests/shell/testcases/optimizations/dumps/merge_stmts_concat.nft tests/shell/testcases/optimizations/merge_stmts_concat+6 -00 replies
2/2optimize: check for mergeable rulessrc/optimize.c tests/shell/testcases/optimizations/dumps/not_mergeable.nft tests/shell/testcases/optimizations/not_mergeable+55 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH nft 0/2] --optimize fixes

Hi,

Two more fixes for the -o/--optimize infrastructure, reported by users after the release:

1) do not hit assert() when concatenation already exists in the ruleset.
2) do not merge rules unless they contain at least one mergeable statement.

Both patches come with tests to illustrate the issues.

Pablo Neira Ayuso (2):
optimize: merging concatenation is unsupported
optimize: check for mergeable rules

 src/optimize.c                                | 32 ++++++++++++++++++-
 .../dumps/merge_stmts_concat.nft              |  1 +
 .../optimizations/dumps/not_mergeable.nft     | 12 +++++++
 .../optimizations/merge_stmts_concat          |  1 +
 .../testcases/optimizations/not_mergeable     | 16 ++++++++++
 5 files changed, 61 insertions(+), 1 deletion(-)
 create mode 100644 tests/shell/testcases/optimizations/dumps/not_mergeable.nft
 create mode 100755 tests/shell/testcases/optimizations/not_mergeable
Signature · 1 line
2.30.2