Skip to content

add remaining SGL support to AESNI_MB

Ciara Power dpdk-dev 5 versions – Applied

Status from this message: Applied to dpdk-next-crypto

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest4 patches 1 replyApplied
  2. v45 patches 1 replySuperseded
  3. v35 patches 6 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v25 patches3 repliesSuperseded
v13 patches0 repliesSuperseded

Changes in v5 from the cover letter

- Rebased on for-main branch after session rework merged.
- Dropped bug fix patch for sessionless tests, no longer applicable after session rework.
- Removed some added AES-XTS tests as they are skipped for AESNI_MB and QAT and I can't verify them locally.
- Added AES-XTS tests that had been accidentally removed in previous patchset versions.

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/4test/crypto: fix wireless auth digest segmentapp/test/test_cryptodev.c+10 -00 replies
2/4crypto/ipsec_mb: add remaining SGL supportdoc/guides/cryptodevs/aesni_mb.rst doc/guides/cryptodevs/features/aesni_mb.ini doc/guides/rel_notes/release_22_11.rst +1 more+156 -340 replies
3/4test/crypto: add OOP snow3g SGL testsapp/test/test_cryptodev.c+39 -90 replies
4/4test/crypto: add remaining blockcipher SGL testsapp/test/test_cryptodev_aes_test_vectors.h app/test/test_cryptodev_blockcipher.c app/test/test_cryptodev_blockcipher.h +1 more+338 -320 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchFan ZhangPablo de Lara
1/4A-b A-b
2/4A-b A-b
3/4A-b A-b
4/4A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/4] add remaining SGL support to AESNI_MB

Currently, the intel-ipsec-mb library only supports SGL for GCM and ChaCha20-Poly1305 algorithms through the JOB API.

To add SGL support for other algorithms, a workaround approach is added in the AESNI_MB PMD. SGL feature flags can now be added to the PMD.

Some additional Snow3G SGL and AES tests are also added for various SGL input/output combinations that were not previously being tested.

v5:
- Rebased on for-main branch after session rework merged.
- Dropped bug fix patch for sessionless tests, no longer applicable after session rework.
- Removed some added AES-XTS tests as they are skipped for AESNI_MB and QAT and I can't verify them locally.
- Added AES-XTS tests that had been accidentally removed in previous patchset versions.

v4: Added error check when appending space for digest to buffer.

v3:
- Modified fix to reset sessions, and ensure values are then set for sessionless testcases. V2 fix just ensured the same values in session objects were reused, as they were not being reset, which was incorrect.
- Reduced code duplication by adding a reusable function.
- Changed int to uint64_t for total_len.

v2:
- Added documentation changes.
- Added fix for sessionless cleanup.
- Modified blockcipher tests to support various SGL types.
- Added more SGL AES tests.
- Small fixes.

Ciara Power (4):
test/crypto: fix wireless auth digest segment crypto/ipsec_mb: add remaining SGL support test/crypto: add OOP snow3g SGL tests test/crypto: add remaining blockcipher SGL tests

 app/test/test_cryptodev.c                   |  58 +++-
 app/test/test_cryptodev_aes_test_vectors.h  | 310 +++++++++++++++++++-
 app/test/test_cryptodev_blockcipher.c       |  50 ++--
 app/test/test_cryptodev_blockcipher.h       |   2 +
 app/test/test_cryptodev_hash_test_vectors.h |   8 +-
 doc/guides/cryptodevs/aesni_mb.rst          |   1 -
 doc/guides/cryptodevs/features/aesni_mb.ini |   4 +
 doc/guides/rel_notes/release_22_11.rst      |   5 +
 drivers/crypto/ipsec_mb/pmd_aesni_mb.c      | 180 +++++++++---
 9 files changed, 543 insertions(+), 75 deletions(-)
Signature · 1 line
2.25.1