Skip to content

virtio: drop sizing vqs during init

Michael S. Tsirkin kvm linux-remoteproc linux-s390 linux-um lkml netdev platform-driver-x86 virtualization 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 0 repliesNew
  2. v35 patches 4 repliesSuperseded
  3. v25 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch8 repliesSuperseded

Changes in v4 from the cover letter

added a vdpa revert

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6virtio_net: Revert "virtio_net: set the default max ring size by find_vqs()"drivers/net/virtio_net.c+4 -380 replies
2/6virtio: Revert "virtio: add helper virtio_find_vqs_ctx_size()"include/linux/virtio_config.h+0 -120 replies
3/6virtio-mmio: Revert "virtio_mmio: support the arg sizes of find_vqs()"drivers/virtio/virtio_mmio.c+2 -60 replies
4/6virtio_pci: Revert "virtio_pci: support the arg sizes of find_vqs()"drivers/virtio/virtio_pci_common.c drivers/virtio/virtio_pci_common.h drivers/virtio/virtio_pci_legacy.c +1 more+12 -230 replies
5/6virtio_vdpa: Revert "virtio_vdpa: support the arg sizes of find_vqs()"drivers/virtio/virtio_vdpa.c+6 -90 replies
5/6virtio: Revert "virtio_vdpa: support the arg sizes of find_vqs()"drivers/virtio/virtio_vdpa.c+6 -90 replies
6/6virtio: Revert "virtio: find_vqs() add arg sizes"arch/um/drivers/virtio_uml.c drivers/platform/mellanox/mlxbf-tmfifo.c drivers/remoteproc/remoteproc_virtio.c +7 more+10 -220 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by.

PatchAndres FreundGuenter Roeck
1/6T-b T-b
2/6
3/6
4/6
5/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/6] virtio: drop sizing vqs during init

Supplying size during init does not work for all transports. In fact for legacy pci doing that causes a memory corruption which was reported on Google Cloud.

We might get away with changing size to size_hint so it's safe to ignore and then fixing legacy to ignore the hint.

But the benefit is unclear in any case, so let's revert for now. Any new version will have to come with
- documentation of performance gains
- performance testing showing existing workflows
are not harmed materially. especially ones with bursty traffic
- report of testing on legacy devices

Huge shout out to Andres Freund for the effort spent reproducing and debugging! Thanks to Guenter Roeck for help with testing!

changes from v3
added a vdpa revert
changes from v2
drop unrelated patches
changes from v1
revert the ring size api, it's unused now

Michael S. Tsirkin (5):
virtio_net: Revert "virtio_net: set the default max ring size by

    find_vqs()"

Michael S. Tsirkin (6):
virtio_net: Revert "virtio_net: set the default max ring size by

    find_vqs()"

Michael S. Tsirkin (6):
virtio_net: Revert "virtio_net: set the default max ring size by

    find_vqs()"

virtio: Revert "virtio: add helper virtio_find_vqs_ctx_size()"
virtio-mmio: Revert "virtio_mmio: support the arg sizes of find_vqs()"
virtio_pci: Revert "virtio_pci: support the arg sizes of find_vqs()"
virtio_vdpa: Revert "virtio_vdpa: support the arg sizes of find_vqs()"
virtio: Revert "virtio: find_vqs() add arg sizes"

 arch/um/drivers/virtio_uml.c             |  2 +-
 drivers/net/virtio_net.c                 | 42 +++---------------------
 drivers/platform/mellanox/mlxbf-tmfifo.c |  1 -
 drivers/remoteproc/remoteproc_virtio.c   |  1 -
 drivers/s390/virtio/virtio_ccw.c         |  1 -
 drivers/virtio/virtio_mmio.c             |  9 ++---
 drivers/virtio/virtio_pci_common.c       | 20 +++++------
 drivers/virtio/virtio_pci_common.h       |  3 +-
 drivers/virtio/virtio_pci_legacy.c       |  6 +---
 drivers/virtio/virtio_pci_modern.c       | 17 +++-------
 drivers/virtio/virtio_vdpa.c             | 16 ++++-----
 include/linux/virtio_config.h            | 26 +++------------
 12 files changed, 34 insertions(+), 110 deletions(-)
Signature · 6 lines
MST

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization