Skip to content

ARM: dts: pci-mvebu: Fix assigned-addresses for every PCIe Root Port

Pali Rohár linux-arm-kernel linux-devicetree lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6ARM: dts: dove: Fix assigned-addresses for every PCIe Root Portarch/arm/boot/dts/dove.dtsi+1 -10 replies
2/6ARM: dts: armada-370: Fix assigned-addresses for every PCIe Root Portarch/arm/boot/dts/armada-370.dtsi+1 -10 replies
3/6ARM: dts: armada-xp: Fix assigned-addresses for every PCIe Root Portarch/arm/boot/dts/armada-xp-mv78230.dtsi arch/arm/boot/dts/armada-xp-mv78260.dtsi+12 -120 replies
4/6ARM: dts: armada-375: Fix assigned-addresses for every PCIe Root Portarch/arm/boot/dts/armada-375.dtsi+1 -10 replies
5/6ARM: dts: armada-38x: Fix assigned-addresses for every PCIe Root Portarch/arm/boot/dts/armada-380.dtsi arch/arm/boot/dts/armada-385.dtsi+5 -50 replies
6/6ARM: dts: armada-39x: Fix assigned-addresses for every PCIe Root Portarch/arm/boot/dts/armada-39x.dtsi+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] ARM: dts: pci-mvebu: Fix assigned-addresses for every PCIe Root Port

Per IEEE Std 1275-1994 bindings documentation (to which kernel DT bindings refers), DT property assigned-addresses contains BDF address of resource. Currently more PCIe Root Port nodes have BDF address in assigned-addresses which points to different PCIe Root Port nodes. This obviously does not make sense as the address resource specified in assigned-addresses of every PCIe Root Port describes address range of internal registers which are specific for corresponding Marvell PCIe Root Port. Fix this issue and align all BDF addresses in assigned-addresses DT property to specify correct BDF address of the current PCIe Root Port.

Note that current version of pci-mvebu.c controller driver, which registers Marvell PCIe Root Ports, ignores BDF value in DT property assigned-addresses. It expects that Root Port's assigned-addresses contains address range of that root port. That is why driver currently works without any issue and nobody spotted it. But if driver or something else would do device tree validation then this issue should be spotted and throws error. Also device tree files may be used by other projects where drivers may require correct values.

This patch series aligns BDF address of every Marvell PCIe Root Port in node name, config space in reg property and mem in assigned-address property of internal registers resource.

Pali Rohár (6):
ARM: dts: dove: Fix assigned-addresses for every PCIe Root Port
ARM: dts: armada-370: Fix assigned-addresses for every PCIe Root Port
ARM: dts: armada-xp: Fix assigned-addresses for every PCIe Root Port
ARM: dts: armada-375: Fix assigned-addresses for every PCIe Root Port
ARM: dts: armada-38x: Fix assigned-addresses for every PCIe Root Port
ARM: dts: armada-39x: Fix assigned-addresses for every PCIe Root Port

 arch/arm/boot/dts/armada-370.dtsi        |  2 +-
 arch/arm/boot/dts/armada-375.dtsi        |  2 +-
 arch/arm/boot/dts/armada-380.dtsi        |  4 ++--
 arch/arm/boot/dts/armada-385.dtsi        |  6 +++---
 arch/arm/boot/dts/armada-39x.dtsi        |  6 +++---
 arch/arm/boot/dts/armada-xp-mv78230.dtsi |  8 ++++----
 arch/arm/boot/dts/armada-xp-mv78260.dtsi | 16 ++++++++--------
 arch/arm/boot/dts/dove.dtsi              |  2 +-
 8 files changed, 23 insertions(+), 23 deletions(-)
Signature · 1 line
2.20.1