Skip to content

linux: implement LoadFile2 initrd loading

Ard Biesheuvel grub-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest6 patches 2 repliesIn review
  2. v46 patches 8 repliesSuperseded
  3. v38 patches 8 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v19 patches2 repliesSuperseded

Changes in v5 from the cover letter

- incorporate review feedback from Daniel regarding whitespace and other minor style deviations

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6efi: move MS-DOS stub out of generic PE header definitiongrub-core/kern/efi/efi.c include/grub/efi/pe32.h+18 -60 replies
2/6linux/arm: unify ARM/arm64 vs Xen PE/COFF header handlinggrub-core/loader/arm64/linux.c grub-core/loader/arm64/xen_boot.c include/grub/arm/linux.h +2 more+21 -250 replies
3/6linux/arm: account for COFF headers appearing at unexpected offsetsgrub-core/loader/arm64/linux.c+15 -00 replies
4/6efi/efinet: Don't close connections at fini_hw() timegrub-core/net/drivers/efi/efinet.c grub-core/net/net.c include/grub/net.h+12 -30 replies
5/6efi: implement LoadFile2 initrd loading protocol for Linuxgrub-core/commands/efi/lsefi.c grub-core/loader/arm64/linux.c include/grub/efi/api.h+164 -10 replies
6/6linux: ignore FDT unless we need to modify itgrub-core/loader/arm64/linux.c grub-core/loader/efi/fdt.c+16 -130 replies

Reviews trailers per patch

3 of 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchHeinrich SchuchardtIlias ApalodimasLeif LindholmDaniel Kiper
SeriesR-b
1/6
2/6
3/6
4/6R-b R-b
5/6R-b T-b R-b
6/6R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/6] linux: implement LoadFile2 initrd loading

This implements the LoadFile2 initrd loading protocol, which is essentially a callback interface into the bootloader to load the initrd data into a caller provided buffer. This means the bootloader no longer has to contain any policy regarding where to load the initrd (which differs between architectures and kernel versions) and no longer has to manipulate arch specific data structures such as DT or struct bootparams to inform the OS where the initrd resides in memory. This is especially relevant for the upcoming LoongArch support, which does not use either DT or struct bootparams, and would have to rely on the initrd= command line interface, which is deprecated and of limited utility [0].

Sample output from booting a recent Linux/arm64 kernel:

grub> insmod part_msdos
grub> linux (hd0,msdos1)/Image
grub> initrd (hd0,msdos1)/initrd.img
grub> boot
EFI stub: Booting Linux Kernel...
EFI stub: EFI_RNG_PROTOCOL unavailable
EFI stub: Generating empty DTB
EFI stub: Loaded initrd from LINUX_EFI_INITRD_MEDIA_GUID device path EFI stub: Exiting boot services...

  [    0.000000] Booting Linux on physical CPU 0x0000000000 [0x411fd070]

Changes since v4:
- incorporate review feedback from Daniel regarding whitespace and other minor style deviations

Changes since v3:
- drop a couple of patches that have been merged independently in the meantime
- update patch #1 to read the PE image header offset from the file instead of using the harcoded offset
- add acks from Heinrich and Ilias

Changes since v2:
- incorporate some ancient feedback from Daniel that I never saw until today. (this is why I am sending two versions of the same series on the same day - apologies for the spam)

[0] The initrd= command line loader can only access files that reside on the same volume as the loaded image, which means GRUB would have to present this volume abstraction in order to serve the initrd file.

Cc Daniel Kiper <[email protected]>
Cc Leif Lindholm <[email protected]>
Cc Nikita Ermakov <[email protected]>
Cc Atish Patra <[email protected]>
Cc Huacai Chen <[email protected]>
Cc Heinrich Schuchardt <[email protected]>
Cc dann frazier <[email protected]>
Cc Julian Andres Klode <[email protected]>
Cc Ilias Apalodimas <[email protected]>

Ard Biesheuvel (6):
efi: move MS-DOS stub out of generic PE header definition linux/arm: unify ARM/arm64 vs Xen PE/COFF header handling linux/arm: account for COFF headers appearing at unexpected offsets efi/efinet: Don't close connections at fini_hw() time
efi: implement LoadFile2 initrd loading protocol for Linux
linux: ignore FDT unless we need to modify it

 grub-core/commands/efi/lsefi.c     |   1 +
 grub-core/kern/efi/efi.c           |   8 +-
 grub-core/loader/arm64/linux.c     | 173 ++++++++++++++++++--
 grub-core/loader/arm64/xen_boot.c  |  23 +--
 grub-core/loader/efi/fdt.c         |   7 +-
 grub-core/net/drivers/efi/efinet.c |  10 +-
 grub-core/net/net.c                |   2 +-
 include/grub/arm/linux.h           |   5 +
 include/grub/arm64/linux.h         |   2 +
 include/grub/efi/api.h             |  40 +++++
 include/grub/efi/efi.h             |   4 +-
 include/grub/efi/pe32.h            |  16 +-
 include/grub/net.h                 |   3 +-
 13 files changed, 246 insertions(+), 48 deletions(-)
Signature · 1 line
2.35.1