Skip to content

A couple of small refactorings of BPF program call sites

Toke Høiland-Jørgensen bpf netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 2 repliesIn review 2 of 3 applied
  2. v23 patches 5 repliesSuperseded
  3. v13 patches 8 repliesSuperseded

Changes in v3 from the cover letter

- In patch 3, don't change types of return values that are copied to userspace (which should fix selftest errors on big-endian archs like s390)
- Rebase on bpf-next
- Collect Song's ACKs

Patches in v3 2 of 3 applied

#Subject and filesSizeRepliesApplied
1/3dev: Move received_rps counter next to RPS members in softnet datainclude/linux/netdevice.h+1 -10 repliesApplied
2/3bpf: Expand map key argument of bpf_redirect_map to u64include/linux/bpf.h include/linux/filter.h include/uapi/linux/bpf.h +5 more+17 -170 repliesApplied
3/3bpf: Use 64-bit return value for bpf_prog_runinclude/linux/bpf-cgroup.h include/linux/bpf.h include/linux/filter.h +4 more+52 -492 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchSong LiuStanislav Fomichev
1/3A-b R-b
2/3A-b R-b
3/3A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH bpf-next v3 0/3] A couple of small refactorings of BPF program call sites

Stanislav suggested[0] that these small refactorings could be split out from the XDP queueing RFC series and merged separately. The first change is a small repacking of struct softnet_data, the others change the BPF call sites to support full 64-bit values as arguments to bpf_redirect_map() and as the return value of a BPF program, relying on the fact that BPF registers are always 64-bit wide to maintain backwards compatibility.

Please see the individual patches for details.

v3:
- In patch 3, don't change types of return values that are copied to userspace (which should fix selftest errors on big-endian archs like s390)
- Rebase on bpf-next
- Collect Song's ACKs

v2:
- Rebase on bpf-next (CI failure seems to be unrelated to this series)
- Collect Stanislav's Reviewed-by

[0] https://lore.kernel.org/r/CAKH8qBtdnku7StcQ-SamadvAF==DRuLLZO94yOR1WJ9Bg=uX1w@mail.gmail.com

Kumar Kartikeya Dwivedi (1):
bpf: Use 64-bit return value for bpf_prog_run

Toke Høiland-Jørgensen (2):
dev: Move received_rps counter next to RPS members in softnet data
bpf: Expand map key argument of bpf_redirect_map to u64

 include/linux/bpf-cgroup.h | 12 +++++------
 include/linux/bpf.h        | 24 +++++++++++-----------
 include/linux/filter.h     | 42 +++++++++++++++++++-------------------
 include/linux/netdevice.h  |  2 +-
 include/uapi/linux/bpf.h   |  2 +-
 kernel/bpf/cgroup.c        | 12 +++++------
 kernel/bpf/core.c          | 14 ++++++-------
 kernel/bpf/cpumap.c        |  4 ++--
 kernel/bpf/devmap.c        |  4 ++--
 kernel/bpf/offload.c       |  4 ++--
 kernel/bpf/verifier.c      |  2 +-
 net/core/filter.c          |  4 ++--
 net/packet/af_packet.c     |  7 +++++--
 net/xdp/xskmap.c           |  4 ++--
 14 files changed, 70 insertions(+), 67 deletions(-)
Signature · 1 line
2.38.1