Skip to content

devlink: remove dl_argv_parse_put

Jacob Keller netdev 1 version Applied

Status from this message: This series was applied to iproute2/iproute2-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2devlink: use dl_no_arg instead of checking dl_argc == 0devlink/devlink.c+16 -161 reply
2/2devlink: remove dl_argv_parse_putdevlink/devlink.c+329 -2581 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJiri Pirko
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [iproute2-next 0/2] devlink: remove dl_argv_parse_put

This series removes the dl_argv_parse_put function which both parses the command line arguments and places them into the netlink header.

This was originally sent as an RFC at
https://lore.kernel.org/netdev/[email protected]/

Since there is some ongoing work around policy code being generated from YAML, I thought it best to wait on the devlink policy portion of this series for now.

Jiri mentioned he wanted to base some work on top of this, so I am sending just the cleanup patches.

The primary motivation for this is due to the fact that dl_argv_parse_put requires a netlink header, meaning a command must have already been prepared. This prevents addition of a different netlink command to get the policy data, and thus prevents us from using this variant while checking netlink policy.

Cc Jacob Keller <[email protected]>
Cc Jonathan Corbet <[email protected]>
Cc Jiri Pirko <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Eric Dumazet <[email protected]>
Cc Jakub Kicinski <[email protected]>
Cc Paolo Abeni <[email protected]>
Cc David Ahern <[email protected]>
Cc Stephen Hemminger <[email protected]>

Jacob Keller (2):
devlink: use dl_no_arg instead of checking dl_argc == 0
devlink: remove dl_argv_parse_put

 devlink/devlink.c | 587 ++++++++++++++++++++++++++--------------------
 1 file changed, 329 insertions(+), 258 deletions(-)

base-commit: 700a8991f05e6e37889101196a531cf82777bdf7

Signature · 1 line
2.37.1.394.gc50926e1f488