Skip to content

vDPA shadow virtqueue iova tree fixes.

Eugenio Pérez qemu-devel 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 0 repliesNew
  2. v17 patches 8 repliesSuperseded

Changes in v2 from the cover letter

* Accept iova_tree_remove map arg by value
* Add error message on unmap fail

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7vdpa: Skip the maps not in the iova treehw/virtio/vhost-vdpa.c+4 -00 replies
2/7vdpa: do not save failed dma maps in SVQ iova treehw/virtio/vhost-vdpa.c+13 -70 replies
3/7util: accept iova_tree_remove_parameter by valuehw/i386/intel_iommu.c hw/virtio/vhost-iova-tree.c hw/virtio/vhost-iova-tree.h +4 more+13 -130 replies
4/7vdpa: Remove SVQ vring from iova_tree at shutdownhw/virtio/vhost-vdpa.c+6 -00 replies
5/7vdpa: Make SVQ vring unmapping return voidhw/virtio/vhost-vdpa.c+10 -220 replies
6/7vhost: Always store new kick fd on vhost_svq_set_svq_kick_fdhw/virtio/vhost-shadow-virtqueue.c+2 -20 replies
7/7vdpa: Use ring hwaddr at vhost_vdpa_svq_unmap_ringhw/virtio/vhost-vdpa.c+8 -90 replies

Reviews trailers per patch

5 of 7 patches have a Reviewed-by or Acked-by.

PatchJason Wang
1/7A-b
2/7A-b
3/7
4/7
5/7A-b
6/7A-b
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] vDPA shadow virtqueue iova tree fixes.

Collection of iova tree fixes detected preparing live migration with real devices and multiqueue.

These cannot be triggered in simple setups (vdpa_sim_net, no display, no device reset with different features) but it's possible to trigger them with real devices or if the kernel fails some step like memory mapping / unmapping.

First two patches are already in the list at [1]. Last one is not a fix by itself but a straightforward merge of the same code.

[1] https://lists.nongnu.org/archive/html/qemu-devel/2022-08/msg00773.html

v2:
* Accept iova_tree_remove map arg by value
* Add error message on unmap fail

Eugenio Pérez (7):
vdpa: Skip the maps not in the iova tree
vdpa: do not save failed dma maps in SVQ iova tree
util: accept iova_tree_remove_parameter by value
vdpa: Remove SVQ vring from iova_tree at shutdown
vdpa: Make SVQ vring unmapping return void
vhost: Always store new kick fd on vhost_svq_set_svq_kick_fd
vdpa: Use ring hwaddr at vhost_vdpa_svq_unmap_ring

 hw/virtio/vhost-iova-tree.h        |  2 +-
 include/qemu/iova-tree.h           |  2 +-
 hw/i386/intel_iommu.c              |  6 +--
 hw/virtio/vhost-iova-tree.c        |  2 +-
 hw/virtio/vhost-shadow-virtqueue.c |  4 +-
 hw/virtio/vhost-vdpa.c             | 75 ++++++++++++++++--------------
 net/vhost-vdpa.c                   |  4 +-
 util/iova-tree.c                   |  4 +-
 8 files changed, 51 insertions(+), 48 deletions(-)
Signature · 1 line
2.31.1