Skip to content

drm/arm/hdlcd: use drm managed resources

Danilo Krummrich dri-devel lkml 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 3 repliesIn review
  2. v37 patches 3 repliesSuperseded
  3. v26 patches 0 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v1 posting 3/37 patches7 repliesSuperseded
v1 posting 2/38 patches1 replySuperseded
v1 posting 1/37 patches0 repliesSuperseded

Changes in v4 from the cover letter

- Remove patches to protect platform device bound resources with drm_dev_{enter,exit}, since this would leave the hardware enabled when regularly unloading the driver e.g. via rmmod.
Instead do this in a later series, once we got drm_dev_unplug() in place to deal with a regular driver shutdown.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/arm/hdlcd: use drmm_* to allocate driver structuresdrivers/gpu/drm/arm/hdlcd_drv.c drivers/gpu/drm/arm/hdlcd_drv.h+5 -80 replies
2/4drm/arm/hdlcd: replace drm->dev_private with drm_to_hdlcd_priv()drivers/gpu/drm/arm/hdlcd_crtc.c drivers/gpu/drm/arm/hdlcd_drv.c drivers/gpu/drm/arm/hdlcd_drv.h+8 -90 replies
3/4drm/arm/hdlcd: plane: use drm managed resourcesdrivers/gpu/drm/arm/hdlcd_crtc.c+6 -120 replies
4/4drm/arm/hdlcd: remove calls to drm_mode_config_cleanup()drivers/gpu/drm/arm/hdlcd_drv.c+13 -60 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLiviu Dudau
SeriesA-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH drm-misc-next v4 0/4] drm/arm/hdlcd: use drm managed resources

Hi,

This patch series converts the driver to use drm managed resources to prevent potential use-after-free issues on driver unbind/rebind and to get rid of the usage of deprecated APIs.

Changes in v2:
- drop patch "drm/arm/hdlcd: crtc: use drmm_crtc_init_with_planes()"

Changes in v3:
- Fix alternate return paths in srcu read-side critical sections causing a stall when unregistering the driver.
- Fix potential null pointer dereference in hdlcd_crtc_cleanup() introduced dropping the patch in v2.
- Add a patch to remove explicit calls to drm_mode_config_cleanup().

Changes in v4:
- Remove patches to protect platform device bound resources with drm_dev_{enter,exit}, since this would leave the hardware enabled when regularly unloading the driver e.g. via rmmod.
Instead do this in a later series, once we got drm_dev_unplug() in place to deal with a regular driver shutdown.

Danilo Krummrich (4):
drm/arm/hdlcd: use drmm_* to allocate driver structures drm/arm/hdlcd: replace drm->dev_private with drm_to_hdlcd_priv() drm/arm/hdlcd: plane: use drm managed resources drm/arm/hdlcd: remove calls to drm_mode_config_cleanup()

 drivers/gpu/drm/arm/hdlcd_crtc.c | 24 +++++++------------
 drivers/gpu/drm/arm/hdlcd_drv.c  | 41 ++++++++++++++++----------------
 drivers/gpu/drm/arm/hdlcd_drv.h  |  2 ++
 3 files changed, 32 insertions(+), 35 deletions(-)

base-commit: e1e7bc481d49c3e3ada11029ce0d9b85a0a539d7

Signature · 1 line
2.37.3