tracing/eprobes: Fixes for unexpected arguments
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest6 patches 3 repliesIn review
- v14 patches 10 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | tracing/eprobes: Do not allow eprobes to use $stack, or % for regskernel/ | +13 | 0 replies | |
| 2/6 | tracing/eprobes: Do not hardcode $comm as a stringkernel/ | +3 | 0 replies | |
| 3/6 | tracing/eprobes: Fix reading of string fieldskernel/ | +21 | 0 replies | |
| 4/6 | tracing/eprobes: Have event probes be consistent with kprobes and uprobeskernel/ | +64 | 0 replies | |
| 5/6 | tracing/probes: Have kprobes and uprobes use $COMM tookernel/ | +3 | 2 replies | |
| 6/6 | tracing: Have filter accept "common_cpu" to be consistentkernel/ | +1 | 1 reply |
Reviews trailers per patch
4 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Masami Hiramatsu (Google) |
|---|---|
| 1/6 | A-b |
| 2/6 | |
| 3/6 | A-b |
| 4/6 | |
| 5/6 | A-b |
| 6/6 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/6] tracing/eprobes: Fixes for unexpected arguments
While using eprobes, I decided to entertain the thougth of what would happen if I tried to get the instruction pointer "%rip", knowing full well that eprobes do not have access to pt_regs. Well, I found out, and it led me down a rabbit hole of bugs.
This series fixes those bugs, by not allowing register access for eprobes, and also filling the holes of @symbol and @immediate argument.
Changes since v1: https://lore.kernel.org/all/[email protected]/
- Fixed parenthesis warning
- Fixed comment about comm arguments
- Made kprobes and eprobes process "$COMM" as well as "$comm"
- Made filters consistent with histograms with "common_cpu"
Steven Rostedt (Google) (6):
tracing/eprobes: Do not allow eprobes to use $stack, or % for regs tracing/eprobes: Do not hardcode $comm as a string tracing/eprobes: Fix reading of string fields tracing/eprobes: Have event probes be consistent with kprobes and uprobes tracing/probes: Have kprobes and uprobes use $COMM too
tracing: Have filter accept "common_cpu" to be consistent
----
kernel/trace/trace_eprobe.c | 91 ++++++++++++++++++++++++++++++++++++++++++--- kernel/trace/trace_events.c | 1 + kernel/trace/trace_probe.c | 29 +++++++++------ 3 files changed, 104 insertions(+), 17 deletions(-)