Skip to content

ice: support FEC automatic disable

Jacob Keller netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 41 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ethtool: pass netlink extended ACK to .set_fecparamdrivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c drivers/net/ethernet/cavium/liquidio/lio_ethtool.c drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c +18 more+41 -213 replies
2/2ice: add support for Auto FEC with FEC disabled via ETHTOOL_SFECPARAMdrivers/net/ethernet/intel/ice/ice_adminq_cmd.h drivers/net/ethernet/intel/ice/ice_common.c drivers/net/ethernet/intel/ice/ice_common.h +3 more+74 -58 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchSimon Horman
1/2A-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/2] ice: support FEC automatic disable

This series implements support for users to configure automatic FEC selection including the option of disabling FEC. It implements similar behavior as a previous submission we made at

https://lore.kernel.org/netdev/[email protected]/

This implementation varies, in that we now honor ETHTOOL_FEC_AUTO | ETHTOOL_FEC_OFF as the new automatic plus disable mode.

This is in line with the request Jakub made to avoid using a new private flag. I opted to use a bit-wise or of the two already supported flags rather than trying to introduce a new flag.

I think this makes sense as essentially this is a request to automatically select but also include "off" as a possible option. I'm not sure if this is the best approach, but it seemed better than trying to add a new ETHTOOL_FEC_AUTO_DISABLE or similarly confusing option. The need for this is due to the quirk of how the ice firmware Link Establishment State Machine works to decide what FEC mode to use.

Current userspace and the API already support multiple bit selection, though it does have the downside of not guaranteeing consistency across drivers... I'm open to alternative suggestions and implementations if someone has a better suggestion.

Some alternatives we've considered already:

1) use a private flag

Rejected for good reason, as private flags are difficult to discover and vary wildly across drivers. It also makes the driver behave differently to the same userspace request which may not be obvious to applications.

2) always treat ETHTOOL_FEC_AUTO as "automatic + allow disable"

This could work, but it means that behavior will differ depending on the firmware version. Users have no way to know that and might be surprised to find the behavior differ across devices which have different firmware which do or don't support this variation of automatic selection.

2) introduce a new FEC mode to the ETHTOOL interface

I considered just adding a brand new flag, but choosing a name here is relatively difficult. Most names read as some sort of "disable automatic selection" which isn't the best meaning.

3) use combined ETHTOOL_FEC_AUTO | ETHTOOL_FEC_OFF (this series)

This version simply accepts a combined bitwise OR of ETHTOOL_FEC_AUTO and ETHTOOL_FEC_OFF. This was previously rejected by ice so it should not cause compatibility issues. The API already supports it, though it was noted the semantics of this combination are not well defined and could behave differently across drivers.

This version has the downside of not being explicit in the API now since drivers may not all interpret this combination the same way. Thats understandably a concern, but I'm not sure what the best approach to avoid that here.

This version does allow users to explicitly request the new behavior, and allows reporting an error when firmware can't support it.

To aid in reporting errors to userspace, I also extended the .set_fecparam to take the netlink extended ACK struct. This allows directly reporting why the option didn't take when using the netlink backed interface for ethtool.

Jacob Keller (2):
ethtool: pass netlink extended ACK to .set_fecparam
ice: add support for Auto FEC with FEC disabled via ETHTOOL_SFECPARAM

 .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c |  3 +-
 .../ethernet/cavium/liquidio/lio_ethtool.c    |  3 +-
 .../ethernet/chelsio/cxgb4/cxgb4_ethtool.c    |  3 +-
 .../ethernet/fungible/funeth/funeth_ethtool.c |  3 +-
 .../ethernet/hisilicon/hns3/hns3_ethtool.c    |  3 +-
 .../net/ethernet/intel/i40e/i40e_ethtool.c    |  3 +-
 .../net/ethernet/intel/ice/ice_adminq_cmd.h   |  1 +
 drivers/net/ethernet/intel/ice/ice_common.c   | 54 ++++++++++++++++++-
 drivers/net/ethernet/intel/ice/ice_common.h   |  1 +
 drivers/net/ethernet/intel/ice/ice_ethtool.c  | 15 ++++--
 drivers/net/ethernet/intel/ice/ice_main.c     |  3 +-
 drivers/net/ethernet/intel/ice/ice_type.h     |  9 +++-
 .../marvell/octeontx2/nic/otx2_ethtool.c      |  3 +-
 .../marvell/prestera/prestera_ethtool.c       |  3 +-
 .../ethernet/mellanox/mlx5/core/en_ethtool.c  |  3 +-
 .../ethernet/netronome/nfp/nfp_net_ethtool.c  |  3 +-
 .../ethernet/pensando/ionic/ionic_ethtool.c   |  3 +-
 .../net/ethernet/qlogic/qede/qede_ethtool.c   |  3 +-
 drivers/net/ethernet/sfc/ethtool_common.c     |  3 +-
 drivers/net/ethernet/sfc/ethtool_common.h     |  3 +-
 .../net/ethernet/sfc/siena/ethtool_common.c   |  3 +-
 .../net/ethernet/sfc/siena/ethtool_common.h   |  3 +-
 drivers/net/netdevsim/ethtool.c               |  3 +-
 include/linux/ethtool.h                       |  3 +-
 net/ethtool/fec.c                             |  2 +-
 net/ethtool/ioctl.c                           |  2 +-
 26 files changed, 115 insertions(+), 26 deletions(-)

base-commit: 90b3bee3a23249977852079b908270afc6ee03bb

Signature · 1 line
2.37.1.394.gc50926e1f488