Skip to content

netlink: support reporting missing attributes

Jakub Kicinski linux-doc netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 0 repliesApplied 6/6
  2. v26 patches 5 repliesSuperseded
  3. v16 patches 5 repliesSuperseded

Changes in v3 from the cover letter

- update cover letter
- minor (non-functional) adjustments to patches 1, 2, 6

Patches in v3 All 6 applied

#Subject and filesSizeRepliesApplied
1/6netlink: factor out extack compositionnet/netlink/af_netlink.c+55 -300 repliesApplied
2/6netlink: add support for ext_ack missing attributesDocumentation/userspace-api/netlink/intro.rst include/linux/netlink.h include/uapi/linux/netlink.h +1 more+36 -20 repliesApplied
3/6netlink: add helpers for extack attr presence checkinginclude/linux/netlink.h include/net/genetlink.h+18 -00 repliesApplied
4/6devlink: use missing attribute ext_acknet/core/devlink.c+20 -210 repliesApplied
5/6ethtool: strset: report missing ETHTOOL_A_STRINGSET_ID via ext_acknet/ethtool/strset.c+1 -10 repliesApplied
6/6ethtool: report missing header via ext_ack in the default handlernet/ethtool/netlink.c+3 -00 repliesApplied

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchJohannes BergIdo Schimmel
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net-next v3 0/6] netlink: support reporting missing attributes

This series adds support for reporting missing attributes in a structured way. We communicate the type of the missing attribute and if it was missing inside a nest the offset of that nest.

Example of (YAML-based) user space reporting ethtool header missing:

Kernel error: missing attribute: .header

I was tempted to integrate the check with the policy but it seems tricky without doing a full scan, and there may be a ton of attrs in the policy. So leaving that for later.

v3:
- update cover letter
- minor (non-functional) adjustments to patches 1, 2, 6
v2:
- add patch 1
- remove the nest attr if the attr is missing in the root

Jakub Kicinski (6):
netlink: factor out extack composition
netlink: add support for ext_ack missing attributes
netlink: add helpers for extack attr presence checking
devlink: use missing attribute ext_ack
ethtool: strset: report missing ETHTOOL_A_STRINGSET_ID via ext_ack
ethtool: report missing header via ext_ack in the default handler

 Documentation/userspace-api/netlink/intro.rst |  7 +-
 include/linux/netlink.h                       | 24 +++++
 include/net/genetlink.h                       |  7 ++
 include/uapi/linux/netlink.h                  |  6 ++
 net/core/devlink.c                            | 41 ++++----
 net/ethtool/netlink.c                         |  3 +
 net/ethtool/strset.c                          |  2 +-
 net/netlink/af_netlink.c                      | 97 +++++++++++++------
 8 files changed, 133 insertions(+), 54 deletions(-)
Signature · 1 line
2.37.2