netlink: support reporting missing attributes
Status from this message: This series was applied to netdev/net-next.git (master)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest6 patches 0 repliesApplied 6/6
- v26 patches 5 repliesSuperseded
- v16 patches 5 repliesSuperseded
Changes in v3 from the cover letter
- update cover letter
- minor (non-functional) adjustments to patches 1, 2, 6
Patches in v3 All 6 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | netlink: factor out extack compositionnet/ | +55 | 0 replies | Applied |
| 2/6 | netlink: add support for ext_ack missing attributesDocumentation/ include/ include/ +1 more | +36 | 0 replies | Applied |
| 3/6 | netlink: add helpers for extack attr presence checkinginclude/ include/ | +18 | 0 replies | Applied |
| 4/6 | devlink: use missing attribute ext_acknet/ | +20 | 0 replies | Applied |
| 5/6 | ethtool: strset: report missing ETHTOOL_A_STRINGSET_ID via ext_acknet/ | +1 | 0 replies | Applied |
| 6/6 | ethtool: report missing header via ext_ack in the default handlernet/ | +3 | 0 replies | Applied |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Johannes Berg | Ido Schimmel |
|---|---|---|
| 1/6 | R-b | |
| 2/6 | R-b | |
| 3/6 | R-b | |
| 4/6 | R-b | |
| 5/6 | R-b | |
| 6/6 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v3 0/6] netlink: support reporting missing attributes
This series adds support for reporting missing attributes in a structured way. We communicate the type of the missing attribute and if it was missing inside a nest the offset of that nest.
Example of (YAML-based) user space reporting ethtool header missing:
Kernel error: missing attribute: .header
I was tempted to integrate the check with the policy but it seems tricky without doing a full scan, and there may be a ton of attrs in the policy. So leaving that for later.
v3:
- update cover letter
- minor (non-functional) adjustments to patches 1, 2, 6
v2:
- add patch 1
- remove the nest attr if the attr is missing in the root
Jakub Kicinski (6):
netlink: factor out extack composition
netlink: add support for ext_ack missing attributes
netlink: add helpers for extack attr presence checking
devlink: use missing attribute ext_ack
ethtool: strset: report missing ETHTOOL_A_STRINGSET_ID via ext_ack
ethtool: report missing header via ext_ack in the default handler
Documentation/userspace-api/netlink/intro.rst | 7 +- include/linux/netlink.h | 24 +++++ include/net/genetlink.h | 7 ++ include/uapi/linux/netlink.h | 6 ++ net/core/devlink.c | 41 ++++---- net/ethtool/netlink.c | 3 + net/ethtool/strset.c | 2 +- net/netlink/af_netlink.c | 97 +++++++++++++------ 8 files changed, 133 insertions(+), 54 deletions(-)
Signature · 1 line
2.37.2