Skip to content

Drop libslirp submodule

Thomas Huth qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest6 patches 3 repliesIn review

Changes in v2 from the cover letter

- Added patches to clean up and adapt the tests
- Rebased the removal patch to the latest version of the master branch

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6tests/docker: Update the debian-all-test-cross container to Debian 11.gitlab-ci.d/container-cross.yml tests/docker/Makefile.include tests/docker/dockerfiles/debian-all-test-cross.docker+8 -30 replies
2/6tests/vm: Add libslirp to the VM teststests/vm/freebsd tests/vm/haiku.x86_64 tests/vm/netbsd+8 -10 replies
3/6tests/lcitool/libvirt-ci: Update the lcitool module to the latest versiontests/lcitool/libvirt-ci+1 -10 replies
4/6tests: Refresh dockerfiles and FreeBSD vars with lcitool.gitlab-ci.d/cirrus/freebsd-12.vars .gitlab-ci.d/cirrus/freebsd-13.vars tests/docker/dockerfiles/opensuse-leap.docker +1 more+4 -40 replies
5/6tests/avocado: Do not run tests that require libslirp if it is not availabletests/avocado/avocado_qemu/__init__.py tests/avocado/info_usernet.py tests/avocado/replay_linux.py+9 -00 replies
6/6Remove the slirp submodule (i.e. compile only with an external libslirp).gitlab-ci.d/buildtest.yml .gitmodules MAINTAINERS +6 more+34 -1470 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSamuel Thibault
SeriesA-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 for-7.2 0/6] Drop libslirp submodule

At the point in time we're going to release QEMU 7.2, all supported host OS distributions will have a libslirp package available, so there is no need anymore for us to ship the slirp submodule. Thus let's clean up the related tests and finally remove the submodule now.

v2:
- Added patches to clean up and adapt the tests
- Rebased the removal patch to the latest version of the master branch

Thomas Huth (6):
tests/docker: Update the debian-all-test-cross container to Debian 11 tests/vm: Add libslirp to the VM tests tests/lcitool/libvirt-ci: Update the lcitool module to the latest
version
tests: Refresh dockerfiles and FreeBSD vars with lcitool tests/avocado: Do not run tests that require libslirp if it is not
available
Remove the slirp submodule (i.e. compile only with an external
libslirp)

 configure                                     |  24 ----
 meson.build                                   | 121 ++++--------------
 .gitlab-ci.d/buildtest.yml                    |  20 ++-
 .gitlab-ci.d/cirrus/freebsd-12.vars           |   2 +-
 .gitlab-ci.d/cirrus/freebsd-13.vars           |   2 +-
 .gitlab-ci.d/container-cross.yml              |   1 -
 .gitmodules                                   |   3 -
 MAINTAINERS                                   |   1 -
 meson_options.txt                             |   5 +-
 scripts/archive-source.sh                     |   2 +-
 scripts/meson-buildoptions.sh                 |   4 +-
 slirp                                         |   1 -
 tests/avocado/avocado_qemu/__init__.py        |   7 +
 tests/avocado/info_usernet.py                 |   1 +
 tests/avocado/replay_linux.py                 |   1 +
 tests/docker/Makefile.include                 |   1 -
 .../dockerfiles/debian-all-test-cross.docker  |   9 +-
 tests/docker/dockerfiles/opensuse-leap.docker |   2 +-
 tests/docker/dockerfiles/ubuntu2004.docker    |   2 +-
 tests/lcitool/libvirt-ci                      |   2 +-
 tests/vm/freebsd                              |   3 +
 tests/vm/haiku.x86_64                         |   3 +-
 tests/vm/netbsd                               |   3 +
 23 files changed, 64 insertions(+), 156 deletions(-)
 delete mode 160000 slirp
Signature · 1 line
2.31.1