Skip to content

xen-blk{front,back}: Fix the broken semantic and flow of feature-persistent

SeongJae Park linux-block lkml stable xen-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 8 repliesIn review
  2. v12 patches 9 repliesSuperseded

Changes in v2 from the cover letter

(https://lore.kernel.org/xen-devel/[email protected]/)
- Fix the wrong feature_persistent caching position of blkfront
- Set blkfront's feature_persistent field setting with simple '&&' instead of 'if' (Pratyush Yadav)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3xen-blkback: Advertise feature-persistent as user requesteddrivers/block/xen-blkback/common.h drivers/block/xen-blkback/xenbus.c+7 -24 replies
2/3xen-blkfront: Advertise feature-persistent as user requesteddrivers/block/xen-blkfront.c+6 -20 replies
3/3xen-blkfront: Cache feature_persistent value before advertisementdrivers/block/xen-blkfront.c+7 -70 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMarek Marczykowski-GóreckiJuergen GrossMaximilian HeynePratyush Yadav
SeriesT-b R-b T-b
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/3] xen-blk{front,back}: Fix the broken semantic and flow of feature-persistent

Changes from v1
(https://lore.kernel.org/xen-devel/[email protected]/)
- Fix the wrong feature_persistent caching position of blkfront
- Set blkfront's feature_persistent field setting with simple '&&' instead of 'if' (Pratyush Yadav)

This patchset fixes misuse of the 'feature-persistent' advertisement semantic (patches 1 and 2), and the wrong timing of the 'feature_persistent' value caching, which made persistent grants feature always disabled.

SeongJae Park (3):
xen-blkback: Advertise feature-persistent as user requested
xen-blkfront: Advertise feature-persistent as user requested
xen-blkfront: Cache feature_persistent value before advertisement

 drivers/block/xen-blkback/common.h |  3 +++
 drivers/block/xen-blkback/xenbus.c |  6 ++++--
 drivers/block/xen-blkfront.c       | 20 ++++++++++++--------
 3 files changed, 19 insertions(+), 10 deletions(-)
Signature · 1 line
2.25.1