Skip to content

s390x: Add migration test for guest TOD clock

Nico Boehr kvm 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 3 repliesIn review
  2. v22 patches 5 repliesSuperseded
  3. v12 patches 3 repliesSuperseded

Changes in v3 from the cover letter

---
- check the clock is really set after setting (thanks Claudio)
- remove unneeded memory clobber (thanks Claudio)
- add comment to explain what we're testing (thanks Christian)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2lib/s390x: move TOD clock related functions to librarylib/s390x/asm/time.h s390x/sck.c+49 -331 reply
2/2s390x: add migration TOD clock tests390x/Makefile s390x/migration-sck.c s390x/unittests.cfg+59 -01 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchClaudio Imbrenda
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [kvm-unit-tests PATCH v3 0/2] s390x: Add migration test for guest TOD clock

v2->v3:
---
- check the clock is really set after setting (thanks Claudio)
- remove unneeded memory clobber (thanks Claudio)
- add comment to explain what we're testing (thanks Christian)

v1->v2:
---
- remove unneeded include
- advance clock by 10 minutes instead of 1 minute (thanks Claudio)
- express get_clock_us() using stck() (thanks Claudio)

The guest TOD clock should not go backwards on migration. Add a test to verify that.

To reduce code duplication, move some of the time-related defined from the sck test to the library.

Nico Boehr (2):
lib/s390x: move TOD clock related functions to library
s390x: add migration TOD clock test

 lib/s390x/asm/time.h  | 50 ++++++++++++++++++++++++++++++++++++++-
 s390x/Makefile        |  1 +
 s390x/migration-sck.c | 54 +++++++++++++++++++++++++++++++++++++++++++
 s390x/sck.c           | 32 -------------------------
 s390x/unittests.cfg   |  4 ++++
 5 files changed, 108 insertions(+), 33 deletions(-)
 create mode 100644 s390x/migration-sck.c
Signature · 1 line
2.36.1