Skip to content

format-patch --force-in-body-from

Junio C Hamano git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesIn review
  2. v12 patches 4 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3pretty: separate out the logic to decide the use of in-body frompretty.c+9 -10 replies
2/3format-patch: allow forcing the use of in-body From: headerDocumentation/git-format-patch.txt builtin/log.c pretty.c +2 more+30 -02 replies
3/3format-patch: learn format.forceInBodyFrom configuration variableDocumentation/config/format.txt Documentation/git-format-patch.txt builtin/log.c +1 more+34 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] format-patch --force-in-body-from

Users may be authoring and committing their commits under the same e-mail address they use to send their patches from, in which case they shouldn't need to use the in-body From: line in their outgoing e-mails. At the receiving end, "git am" will use the address on the "From:" header of the incoming e-mail and all should be well.

Some mailing lists, however, mangle the From: address from what the original sender had; in such an unfortunate situation, the user may want to add the in-body "From:" header even for their own patch.

A new option --force-in-body-from from the command line of git format-patch, and a new configuration variable format.forceInBodyFrom that can be set per repository, are added to address this.

Changes since the original submission are

* The configuration variable support is new.

* comes with documentation updates.

* "in-body" is spelled as such, not "inbody".

* the order of config and option parsing plus initializing the rev_info structure dictates a separate variable to be used for the former two and then copied to rev_info later.

Junio C Hamano (3):
pretty: separate out the logic to decide the use of in-body from
format-patch: allow forcing the use of in-body From: header
format-patch: learn format.forceInBodyFrom configuration variable

 Documentation/config/format.txt    |  4 ++++
 Documentation/git-format-patch.txt | 11 +++++++++
 builtin/log.c                      |  9 ++++++++
 pretty.c                           | 12 +++++++++-
 revision.h                         |  1 +
 t/t4014-format-patch.sh            | 37 ++++++++++++++++++++++++++++++
 6 files changed, 73 insertions(+), 1 deletion(-)
Signature · 1 line
2.37.2-621-gd3a800faf0