convert most filesystems to pin_user_pages_fast()
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest7 patches 47 repliesIn review
- v16 patches 24 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | mm: change release_pages() to use unsigned long for npagesinclude/ mm/ | +4 | 0 replies | |
| 2/7 | mm/gup: introduce pin_user_page()include/ mm/ | +51 | 2 replies | |
| 3/7 | block: add dio_w_*() wrappers for pin, unpin user pagesblock/ include/ | +61 | 0 replies | |
| 4/7 | iov_iter: new iov_iter_pin_pages*() routinesinclude/ lib/ | +84 | 34 replies | |
| 5/7 | block, bio, fs: convert most filesystems to pin_user_pages_fast()block/ block/ fs/ +1 more | +39 | 2 replies | |
| 6/7 | NFS: direct-io: convert to FOLL_PIN pagesfs/ | +12 | 2 replies | |
| 7/7 | fuse: convert direct IO paths to use FOLL_PINfs/ fs/ fs/ | +31 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/7] convert most filesystems to pin_user_pages_fast()
This is v2. Changes since v1 are:
* Incorporated feedback from Al Viro and Jan Kara: this approach now pins both bvecs (ITER_BVEC) and user pages (user_backed_iter()) with FOLL_PIN.
* Incorporated David Hildenbrand's feedback: Rewrote pin_user_pages() documentation and added a WARN_ON_ONCE() to somewhat enforce the rule that this new function is only intended for use on file-backed pages.
* Added a tiny new patch to fix up the release_pages() number of pages argument, so as to avoid a lot of impedance-matching checks in subsequent patches.
v1 is here:
https://lore.kernel.org/all/[email protected]/
Original cover letter still applies, here it is for convenience:
This converts the iomap core and bio_release_pages() to pin_user_pages_fast(), also referred to as FOLL_PIN here.
The conversion is temporarily guarded by CONFIG_BLK_USE_PIN_USER_PAGES_FOR_DIO. In the future (not part of this series), when we are certain that all filesystems have converted their Direct IO paths to FOLL_PIN, then we can do the final step, which is to get rid of CONFIG_BLK_USE_PIN_USER_PAGES_FOR_DIO and search-and-replace the dio_w_*() functions with their final names (see bvec.h changes).
I'd like to get this part committed at some point, because it seems to work well already. And this will help get the remaining items, below, converted.
Status: although many filesystems have been converted, some remain to be investigated. These include (you can recreate this list by grepping for iov_iter_get_pages):
cephfs cifs 9P RDS net/core: datagram.c, skmsg.c net/tls fs/splice.c
Testing: this passes some light LTP and xfstest runs and fio and a few other things like that, on my local x86_64 test machine, both with and without CONFIG_BLK_USE_PIN_USER_PAGES_FOR_DIO being set.
Conflicts: Logan, the iov_iter parts of this will conflict with your [PATCH v9 2/8] iov_iter: introduce iov_iter_get_pages_[alloc_]flags(), but I think it's easy to resolve.
John Hubbard (7):
mm: change release_pages() to use unsigned long for npages mm/gup: introduce pin_user_page()
block: add dio_w_*() wrappers for pin, unpin user pages
iov_iter: new iov_iter_pin_pages*() routines
block, bio, fs: convert most filesystems to pin_user_pages_fast()
NFS: direct-io: convert to FOLL_PIN pages
fuse: convert direct IO paths to use FOLL_PIN
block/Kconfig | 24 +++++++++++++ block/bio.c | 27 +++++++------- block/blk-map.c | 7 ++-- fs/direct-io.c | 40 ++++++++++----------- fs/fuse/dev.c | 11 ++++-- fs/fuse/file.c | 32 +++++++++++------ fs/fuse/fuse_i.h | 1 + fs/iomap/direct-io.c | 2 +- fs/nfs/direct.c | 22 ++++++------ include/linux/bvec.h | 37 +++++++++++++++++++ include/linux/mm.h | 3 +- include/linux/uio.h | 4 +++ lib/iov_iter.c | 86 ++++++++++++++++++++++++++++++++++++++++---- mm/gup.c | 50 ++++++++++++++++++++++++++ mm/swap.c | 6 ++-- 15 files changed, 282 insertions(+), 70 deletions(-)
base-commit: dcf8e5633e2e69ad60b730ab5905608b756a032f
Signature · 1 line
2.37.2