Skip to content

RFC drm/i915/vm_bind: Add VM_BIND functionality

Andi Shyti dri-devel intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 RFC Latest17 patches 23 repliesIn review

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17drm/i915: Expose vm_lookup in i915_gem_context.hdrivers/gpu/drm/i915/gem/i915_gem_context.c drivers/gpu/drm/i915/gem/i915_gem_context.h+13 -10 replies
2/17drm/i915: Mark vm for vm_bind usage at creationdrivers/gpu/drm/i915/gem/i915_gem_context.c drivers/gpu/drm/i915/gt/intel_gtt.h include/uapi/drm/i915_drm.h+14 -20 replies
3/17drm/i915/gem: expose i915_gem_object_max_page_size() in i915_gem_object.hdrivers/gpu/drm/i915/gem/i915_gem_create.c drivers/gpu/drm/i915/gem/i915_gem_object.h+15 -30 replies
4/17drm/i915: Implement bind and unbind of objectdrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/gem/i915_gem_vm_bind.h drivers/gpu/drm/i915/gem/i915_gem_vm_bind_object.c +7 more+543 -39 replies
5/17drm/i915: Support for VM private BOsdrivers/gpu/drm/i915/gem/i915_gem_object_types.h drivers/gpu/drm/i915/gem/i915_gem_vm_bind_object.c drivers/gpu/drm/i915/gt/intel_gtt.c +3 more+21 -01 reply
6/17drm/i915/dmabuf: Deny the dmabuf export for VM private BOsdrivers/gpu/drm/i915/gem/i915_gem_dmabuf.c+6 -00 replies
7/17drm/i915/vm_bind: Handle persistent vmasdrivers/gpu/drm/i915/gem/i915_gem_object.c drivers/gpu/drm/i915/gem/i915_gem_vm_bind_object.c drivers/gpu/drm/i915/gt/intel_gtt.c +6 more+169 -173 replies
8/17drm/i915/vm_bind: Add out fence supportdrivers/gpu/drm/i915/gem/i915_gem_vm_bind.h drivers/gpu/drm/i915/gem/i915_gem_vm_bind_object.c drivers/gpu/drm/i915/i915_vma.c +1 more+97 -11 reply
9/17drm/i915: Do not support vm_bind mode in execbuf2drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c+5 -01 reply
10/17drm/i915/vm_bind: Implement I915_GEM_EXECBUFFER3 ioctldrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/gem/i915_gem_execbuffer3.c drivers/gpu/drm/i915/gem/i915_gem_ioctls.h +1 more+1065 -06 replies
11/17drm/i915: Add i915_vma_is_bind_complete()drivers/gpu/drm/i915/i915_vma.c drivers/gpu/drm/i915/i915_vma.h+29 -00 replies
12/17drm/i915/vm_bind: Handle persistent vmas in execbuf3drivers/gpu/drm/i915/gem/i915_gem_execbuffer3.c+199 -10 replies
13/17drm/i915/vm_bind: userptr dma-resv changesdrivers/gpu/drm/i915/gem/i915_gem_execbuffer3.c drivers/gpu/drm/i915/gem/i915_gem_userptr.c drivers/gpu/drm/i915/gem/i915_gem_vm_bind_object.c +3 more+142 -311 reply
14/17drm/i915/vm_bind: Skip vma_lookup for persistent vmasdrivers/gpu/drm/i915/display/intel_fb_pin.c drivers/gpu/drm/i915/display/intel_plane_initial.c drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +34 more+106 -930 replies
15/17drm/i915: Extend getparm for VM_BIND capabilitydrivers/gpu/drm/i915/i915_getparam.c include/uapi/drm/i915_drm.h+24 -00 replies
16/17drm/i915/ioctl: Enable the vm_bind/unbind ioctlsdrivers/gpu/drm/i915/i915_driver.c include/uapi/drm/i915_drm.h+6 -00 replies
17/17drm/i915: Enable execbuf3 ioctl for vm_binddrivers/gpu/drm/i915/i915_driver.c include/uapi/drm/i915_drm.h+3 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [RFC PATCH v3 00/17] drm/i915/vm_bind: Add VM_BIND functionality

Hi,

just sending the original Niranjana's patch as an RFC. It's v3 as the v2 has been reviewed offline with Ramalingam.

I'm still keeping most of the structure even though some further discussion can be done starting from here.

Copy pasting Niranjana's original cover letter message:

DRM_I915_GEM_VM_BIND/UNBIND ioctls allows UMD to bind/unbind GEM buffer objects (BOs) or sections of a BOs at specified GPU virtual addresses on a specified address space (VM). Multiple mappings can map to the same physical pages of an object (aliasing). These mappings (also referred to as persistent mappings) will be persistent across multiple GPU submissions (execbuf calls) issued by the UMD, without user having to provide a list of all required mappings during each submission (as required by older execbuf mode).

This patch series support VM_BIND version 1, as described by the param I915_PARAM_VM_BIND_VERSION.

Add new execbuf3 ioctl (I915_GEM_EXECBUFFER3) which only works in vm_bind mode. The vm_bind mode only works with this new execbuf3 ioctl. The new execbuf3 ioctl will not have any execlist support and all the legacy support like relocations etc., are removed.

TODOs:
* Support out fence for VM_UNBIND ioctl.
* Async VM_UNBIND support.
* Share code between execbuf2 and execbuf3 where possible.
* Cleanups and optimizations.

NOTEs:
* It is based on below VM_BIND design+uapi patch series.
https://lists.freedesktop.org/archives/intel-gfx/2022-July/300760.html

* The IGT RFC series is posted as,
[RFC 0/5] vm_bind: Add VM_BIND validation support

Niranjana Vishwanathapura (17):
drm/i915: Expose vm_lookup in i915_gem_context.h drm/i915: Mark vm for vm_bind usage at creation drm/i915/gem: expose i915_gem_object_max_page_size() in

    i915_gem_object.h

drm/i915: Implement bind and unbind of object drm/i915: Support for VM private BOs drm/i915/dmabuf: Deny the dmabuf export for VM private BOs drm/i915/vm_bind: Handle persistent vmas drm/i915/vm_bind: Add out fence support drm/i915: Do not support vm_bind mode in execbuf2 drm/i915/vm_bind: Implement I915_GEM_EXECBUFFER3 ioctl drm/i915: Add i915_vma_is_bind_complete() drm/i915/vm_bind: Handle persistent vmas in execbuf3 drm/i915/vm_bind: userptr dma-resv changes drm/i915/vm_bind: Skip vma_lookup for persistent vmas drm/i915: Extend getparm for VM_BIND capability drm/i915/ioctl: Enable the vm_bind/unbind ioctls drm/i915: Enable execbuf3 ioctl for vm_bind

 drivers/gpu/drm/i915/Makefile                 |    2 +
 drivers/gpu/drm/i915/display/intel_fb_pin.c   |    2 +-
 .../drm/i915/display/intel_plane_initial.c    |    2 +-
 drivers/gpu/drm/i915/gem/i915_gem_context.c   |   16 +-
 drivers/gpu/drm/i915/gem/i915_gem_context.h   |    3 +
 drivers/gpu/drm/i915/gem/i915_gem_create.c    |   16 +-
 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c    |    6 +
 .../gpu/drm/i915/gem/i915_gem_execbuffer.c    |    9 +-
 .../gpu/drm/i915/gem/i915_gem_execbuffer3.c   | 1275 +++++++++++++++++
 drivers/gpu/drm/i915/gem/i915_gem_ioctls.h    |    2 +
 drivers/gpu/drm/i915/gem/i915_gem_object.c    |    1 +
 drivers/gpu/drm/i915/gem/i915_gem_object.h    |    2 +
 .../gpu/drm/i915/gem/i915_gem_object_types.h  |    3 +
 drivers/gpu/drm/i915/gem/i915_gem_userptr.c   |   10 +
 drivers/gpu/drm/i915/gem/i915_gem_vm_bind.h   |   24 +
 .../drm/i915/gem/i915_gem_vm_bind_object.c    |  437 ++++++
 .../gpu/drm/i915/gem/selftests/huge_pages.c   |   16 +-
 .../i915/gem/selftests/i915_gem_client_blt.c  |    2 +-
 .../drm/i915/gem/selftests/i915_gem_context.c |   12 +-
 .../drm/i915/gem/selftests/i915_gem_migrate.c |    2 +-
 .../drm/i915/gem/selftests/i915_gem_mman.c    |    6 +-
 .../drm/i915/gem/selftests/igt_gem_utils.c    |    2 +-
 drivers/gpu/drm/i915/gt/gen6_ppgtt.c          |    2 +-
 drivers/gpu/drm/i915/gt/intel_engine_cs.c     |    2 +-
 drivers/gpu/drm/i915/gt/intel_gt.c            |    2 +-
 drivers/gpu/drm/i915/gt/intel_gtt.c           |   20 +-
 drivers/gpu/drm/i915/gt/intel_gtt.h           |   27 +
 drivers/gpu/drm/i915/gt/intel_lrc.c           |    4 +-
 drivers/gpu/drm/i915/gt/intel_renderstate.c   |    2 +-
 drivers/gpu/drm/i915/gt/intel_ring.c          |    2 +-
 .../gpu/drm/i915/gt/intel_ring_submission.c   |    4 +-
 drivers/gpu/drm/i915/gt/intel_timeline.c      |    2 +-
 drivers/gpu/drm/i915/gt/mock_engine.c         |    2 +-
 drivers/gpu/drm/i915/gt/selftest_engine_cs.c  |    4 +-
 drivers/gpu/drm/i915/gt/selftest_execlists.c  |   16 +-
 drivers/gpu/drm/i915/gt/selftest_hangcheck.c  |    6 +-
 drivers/gpu/drm/i915/gt/selftest_lrc.c        |    2 +-
 .../drm/i915/gt/selftest_ring_submission.c    |    2 +-
 drivers/gpu/drm/i915/gt/selftest_rps.c        |    2 +-
 .../gpu/drm/i915/gt/selftest_workarounds.c    |    4 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc.c        |    2 +-
 drivers/gpu/drm/i915/i915_driver.c            |    4 +
 drivers/gpu/drm/i915/i915_gem.c               |    2 +-
 drivers/gpu/drm/i915/i915_gem_gtt.c           |   38 +
 drivers/gpu/drm/i915/i915_gem_gtt.h           |    3 +
 drivers/gpu/drm/i915/i915_getparam.c          |    3 +
 drivers/gpu/drm/i915/i915_perf.c              |    2 +-
 drivers/gpu/drm/i915/i915_vma.c               |  114 +-
 drivers/gpu/drm/i915/i915_vma.h               |   62 +-
 drivers/gpu/drm/i915/i915_vma_types.h         |   49 +
 drivers/gpu/drm/i915/selftests/i915_gem_gtt.c |   44 +-
 drivers/gpu/drm/i915/selftests/i915_request.c |    4 +-
 drivers/gpu/drm/i915/selftests/i915_vma.c     |    2 +-
 drivers/gpu/drm/i915/selftests/igt_spinner.c  |    2 +-
 .../drm/i915/selftests/intel_memory_region.c  |    2 +-
 include/uapi/drm/i915_drm.h                   |  255 +++-
 56 files changed, 2424 insertions(+), 119 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/gem/i915_gem_execbuffer3.c
 create mode 100644 drivers/gpu/drm/i915/gem/i915_gem_vm_bind.h
 create mode 100644 drivers/gpu/drm/i915/gem/i915_gem_vm_bind_object.c
Signature · 1 line
2.34.1