Skip to content

Introduce AMD GPU ISA Debugging for HSA Compute

Jonathan Kim amd-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest29 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/29drm/amdkfd: add debug and runtime enable interfacedrivers/gpu/drm/amd/amdkfd/kfd_chardev.c include/uapi/linux/kfd_ioctl.h+609 -11 reply
2/29drm/amdkfd: display debug capabilitiesdrivers/gpu/drm/amd/amdkfd/kfd_topology.c drivers/gpu/drm/amd/amdkfd/kfd_topology.h include/uapi/linux/kfd_sysfs.h+104 -50 replies
3/29drm/amdkfd: prepare per-process debug enable and disabledrivers/gpu/drm/amd/amdkfd/Makefile drivers/gpu/drm/amd/amdkfd/kfd_chardev.c drivers/gpu/drm/amd/amdkfd/kfd_debug.c +4 more+308 -290 replies
4/29drm/amdgpu: add kgd hw debug mode setting interfacedrivers/gpu/drm/amd/include/kgd_kfd_interface.h+34 -00 replies
5/29drm/amdgpu: setup hw debug registers on driver initializationdrivers/gpu/drm/amd/amdgpu/gfx_v10_0.c drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c +5 more+163 -00 replies
6/29drm/amdgpu: add gfx9 hw debug mode enable and disable callsdrivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.h drivers/gpu/drm/amd/amdkfd/kfd_debug.h+102 -100 replies
7/29drm/amdgpu: add gfx9.4.1 hw debug mode enable and disable callsdrivers/gpu/drm/amd/amdgpu/amdgpu.h drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +1 more+110 -40 replies
8/29drm/amdgpu: add gfx10 hw debug mode enable and disable callsdrivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.h drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10_3.c+126 -1440 replies
9/29drm/amdgpu: add gfx9.4.2 hw debug mode enable and disable callsdrivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_aldebaran.c+33 -10 replies
10/29drm/amdgpu: add configurable grace period for unmap queuesdrivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_aldebaran.c drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c +10 more+291 -200 replies
11/29drm/amdkfd: prepare map process for single process debug devicesdrivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.h drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c +1 more+115 -50 replies
12/29drm/amdgpu: prepare map process for multi-process debug devicesdrivers/gpu/drm/amd/amdkfd/kfd_debug.h drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.h +3 more+89 -00 replies
13/29drm/amdkfd: add per process hw trap enable and disable functionsdrivers/gpu/drm/amd/amdkfd/kfd_chardev.c drivers/gpu/drm/amd/amdkfd/kfd_debug.c drivers/gpu/drm/amd/amdkfd/kfd_debug.h +2 more+170 -20 replies
14/29drm/amdkfd: add raise exception event functiondrivers/gpu/drm/amd/amdkfd/kfd_debug.c drivers/gpu/drm/amd/amdkfd/kfd_debug.h drivers/gpu/drm/amd/amdkfd/kfd_priv.h+102 -00 replies
15/29drm/amdkfd: add send exception operationdrivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c drivers/gpu/drm/amd/amdkfd/kfd_chardev.c drivers/gpu/drm/amd/amdkfd/kfd_debug.c +5 more+134 -60 replies
16/29drm/amdkfd: add runtime enable operationdrivers/gpu/drm/amd/amdkfd/kfd_chardev.c drivers/gpu/drm/amd/amdkfd/kfd_debug.c drivers/gpu/drm/amd/amdkfd/kfd_debug.h +1 more+148 -30 replies
17/29drm/amdkfd: Add debug trap enabled flag to TMAdrivers/gpu/drm/amd/amdkfd/kfd_debug.c drivers/gpu/drm/amd/amdkfd/kfd_priv.h drivers/gpu/drm/amd/amdkfd/kfd_process.c+22 -00 replies
18/29drm/amdkfd: update process interrupt handling for debug eventsdrivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h drivers/gpu/drm/amd/amdkfd/Makefile +8 more+631 -101 reply
19/29drm/amdkfd: add debug set exceptions enabled operationdrivers/gpu/drm/amd/amdkfd/kfd_chardev.c drivers/gpu/drm/amd/amdkfd/kfd_debug.c drivers/gpu/drm/amd/amdkfd/kfd_debug.h+41 -00 replies
20/29drm/amdkfd: add debug wave launch override operationdrivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_aldebaran.c drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c +7 more+261 -10 replies
21/29drm/amdkfd: add debug wave launch mode operationdrivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_aldebaran.c drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c +7 more+119 -50 replies
22/29drm/amdkfd: add debug suspend and resume process queues operationdrivers/gpu/drm/amd/amdkfd/kfd_chardev.c drivers/gpu/drm/amd/amdkfd/kfd_debug.c drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c +4 more+454 -60 replies
23/29drm/amdkfd: add debug set and clear address watch points operationdrivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_aldebaran.c drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c +9 more+405 -40 replies
24/29drm/amdkfd: add debug set flags operationdrivers/gpu/drm/amd/amdkfd/kfd_chardev.c drivers/gpu/drm/amd/amdkfd/kfd_debug.c drivers/gpu/drm/amd/amdkfd/kfd_debug.h+38 -00 replies
25/29drm/amdkfd: add debug query event operationdrivers/gpu/drm/amd/amdkfd/kfd_chardev.c drivers/gpu/drm/amd/amdkfd/kfd_debug.c drivers/gpu/drm/amd/amdkfd/kfd_debug.h+75 -00 replies
26/29drm/amdkfd: add debug query exception info operationdrivers/gpu/drm/amd/amdkfd/kfd_chardev.c drivers/gpu/drm/amd/amdkfd/kfd_debug.c drivers/gpu/drm/amd/amdkfd/kfd_debug.h+133 -00 replies
27/29drm/amdkfd: add debug queue snapshot operationdrivers/gpu/drm/amd/amdkfd/kfd_chardev.c drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.h +2 more+96 -00 replies
28/29drm/amdkfd: add debug device snapshot operationdrivers/gpu/drm/amd/amdkfd/kfd_chardev.c drivers/gpu/drm/amd/amdkfd/kfd_debug.c drivers/gpu/drm/amd/amdkfd/kfd_debug.h+62 -20 replies
29/29drm/amdkfd: bump kfd ioctl minor version for debug api availabilitydrivers/gpu/drm/amd/amdkfd/kfd_chardev.c include/uapi/linux/kfd_ioctl.h+2 -20 replies

Reviews trailers per patch

1 of 29 patches has a Reviewed-by or Acked-by.

PatchFelix Kuehling
1/29
2/29
3/29
4/29
5/29
6/29
7/29
8/29
9/29
10/29
11/29
12/29
13/29
14/29
15/29
16/29
17/29R-b
18/29
19/29
20/29
21/29
22/29
23/29
24/29
25/29
26/29
27/29
28/29
29/29

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/29] Introduce AMD GPU ISA Debugging for HSA Compute

This series is to expose the required KFD IOCTLs targeted to enable ROCm's extension of the GNU Debugger for HSA compute debugging.

The series is divided into the following sections:

Section 1 - Drawing out the interfaces and preparing the KFD for enable/disable calls
[PATCH 01/29] drm/amdkfd: add debug and runtime enable interface [PATCH 02/29] drm/amdkfd: display debug capabilities [PATCH 03/29] drm/amdkfd: prepare per-process debug enable and

Section 2 - HW initialization and handling the per device HW debug mode enable/disable requirement
[PATCH 04/29] drm/amdgpu: add kgd hw debug mode setting interface [PATCH 05/29] drm/amdgpu: setup hw debug registers on driver [PATCH 06/29] drm/amdgpu: add gfx9 hw debug mode enable and disable [PATCH 07/29] drm/amdgpu: add gfx9.4.1 hw debug mode enable and [PATCH 08/29] drm/amdgpu: add gfx10 hw debug mode enable and disable [PATCH 09/29] drm/amdgpu: add gfx9.4.2 hw debug mode enable and

Section 3 - Preparation for HW debug mode setting and event handling
[PATCH 10/29] drm/amdgpu: add configurable grace period for unmap [PATCH 11/29] drm/amdkfd: prepare map process for single process [PATCH 12/29] drm/amdgpu: prepare map process for multi-process debug [PATCH 13/29] drm/amdkfd: add per process hw trap enable and disable [PATCH 14/29] drm/amdkfd: add raise exception event function [PATCH 15/29] drm/amdkfd: add send exception operation [PATCH 16/29] drm/amdkfd: add runtime enable operation [PATCH 17/29] drm/amdkfd: Add debug trap enabled flag to TMA [PATCH 18/29] drm/amdkfd: update process interrupt handling for debug

Section 4 - Implementation of the HW debug mode setting operations
[PATCH 19/29] drm/amdkfd: add debug set exceptions enabled operation [PATCH 20/29] drm/amdkfd: add debug wave launch override operation [PATCH 21/29] drm/amdkfd: add debug wave launch mode operation [PATCH 22/29] drm/amdkfd: add debug suspend and resume process queues [PATCH 23/29] drm/amdkfd: add debug set and clear address watch [PATCH 24/29] drm/amdkfd: add debug set flags operation [PATCH 25/29] drm/amdkfd: add debug query event operation [PATCH 26/29] drm/amdkfd: add debug query exception info operation [PATCH 27/29] drm/amdkfd: add debug queue snapshot operation [PATCH 28/29] drm/amdkfd: add debug device snapshot operation

Section 5 - Final version bump for interface access checks
[PATCH 29/29] drm/amdkfd: bump kfd ioctl minor version for debug api

BR,

Jon