Skip to content

RFC mac80211: add TPC support in control path

Jonas Jelonek linux-wireless oe-lkp 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest6 patches 16 repliesIn review
  2. v1 RFC4 patches 12 repliesSuperseded

Changes in v2 from the cover letter

- added exemplary hwsim support
- added debugfs in minstrel_ht for fixed TPC
---

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6mac80211: modify tx-power level annotationinclude/net/mac80211.h+26 -62 replies
2/6mac80211: add tx-power annotation in control pathinclude/net/mac80211.h+16 -51 reply
3/6mac80211: add hardware flags for TPC supportinclude/net/mac80211.h net/mac80211/debugfs.c+11 -00 replies
4/6mac80211: add utility function for tx_rate - rate_info conversioninclude/net/mac80211.h net/mac80211/util.c+39 -04 replies
5/6mac80211_hwsim: add TPC per packet supportdrivers/net/wireless/mac80211_hwsim.c drivers/net/wireless/mac80211_hwsim.h+168 -88 replies
6/6mac80211: minstrel_ht - add debugfs entry per sta for fixed tx-powernet/mac80211/rc80211_minstrel_ht.c net/mac80211/rc80211_minstrel_ht.h net/mac80211/rc80211_minstrel_ht_debugfs.c+36 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [RFC v2 0/6] mac80211: add TPC support in control path

Transmit power control (TPC) per packet hence per station can be used to manage interference and increase overall spatial reuse and therefore increases sum throughput in WiFi networks with multiple APs and STAs. Although several of today's wifi chips, e.g., from QCA and from Mediatek support fine-grained TPC per packet, the Linux mac80211 layer does not provide support for this annotation nor control yet.

This series proposes several changes to introduce TPC support in mac80211, in particular to annotate tx-power per packet/per mrr stage in the tx control path.
The patches include new members in the tx control path structs, a modified tx-power level support annotation, hardware flags, hwsim support, debugfs support in minstrel_ht for fixed TPC and an utility function for the convenient use of struct ieee80211_rate_status (introduced by 44fa75f207d8a106bc75e6230db61e961fdbf8a8) for tx-power status report in drivers.
An proof-of-concept ath9k support was implemented for testing these changes on real ath9k hardware, this implementation is planned to be brought upstream later.

Compile-Tested: current wireless-next tree with all flags on
Tested-on: PCEngines APU with ath9k WiFi device on OpenWrt Linux

	Kernel 5.15.68, AP<->STA setup with both ath9k and hwsim
	(used current OpenWrt testing kernel)

---
v2:
- added exemplary hwsim support
- added debugfs in minstrel_ht for fixed TPC
---

Jonas Jelonek (6):
mac80211: modify tx-power level annotation
mac80211: add tx-power annotation in control path
mac80211: add hardware flags for TPC support
mac80211: add utility function for tx_rate - rate_info conversion
mac80211_hwsim: add TPC per packet support
mac80211: minstrel_ht - add debugfs entry per sta for fixed tx-power

 drivers/net/wireless/mac80211_hwsim.c      | 175 ++++++++++++++++++++-
 drivers/net/wireless/mac80211_hwsim.h      |   1 +
 include/net/mac80211.h                     |  66 ++++++--
 net/mac80211/debugfs.c                     |   2 +
 net/mac80211/rc80211_minstrel_ht.c         |  14 ++
 net/mac80211/rc80211_minstrel_ht.h         |  11 ++
 net/mac80211/rc80211_minstrel_ht_debugfs.c |  11 ++
 net/mac80211/util.c                        |  35 +++++
 8 files changed, 296 insertions(+), 19 deletions(-)
Signature · 1 line
2.30.2