Skip to content

Prepare for constifying SCSI host templates

Bart Van Assche linux-scsi 7 versions – Applied

Status from this message: Applied to 6.2/scsi-staging, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest8 patches 2 repliesApplied
  2. v68 patches 2 repliesSuperseded
  3. v57 patches 13 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v44 patches10 repliesSuperseded
v33 patches5 repliesSuperseded
v22 patches6 repliesSuperseded
v12 patches0 repliesSuperseded

Changes in v7 from the cover letter

- Rebased this patch series on top of kernel v6.1-rc1.

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/8scsi: esas2r: Initialize two host template members implicitlydrivers/scsi/esas2r/esas2r_main.c+0 -20 replies
2/8scsi: esas2r: Introduce scsi_template_proc_dir()drivers/scsi/esas2r/esas2r_main.c drivers/scsi/scsi_proc.c include/scsi/scsi_host.h+28 -60 replies
3/8scsi: core: Fail host creation if creating the proc directory failsdrivers/scsi/hosts.c drivers/scsi/scsi_priv.h drivers/scsi/scsi_proc.c+13 -70 replies
4/8scsi: core: Introduce a new list for SCSI proc directory entriesdrivers/scsi/scsi_priv.h drivers/scsi/scsi_proc.c include/scsi/scsi_host.h+102 -350 replies
5/8scsi: core: Rework scsi_single_lun_run()drivers/scsi/scsi_lib.c+15 -170 replies
6/8scsi: ufs: Simplify ufshcd_set_dev_pwr_mode()drivers/ufs/core/ufshcd.c+2 -70 replies
7/8scsi: core: Remove the put_device() call from scsi_device_get()drivers/scsi/scsi.c+5 -50 replies
8/8scsi: core: Release SCSI devices synchronouslydrivers/scsi/scsi.c drivers/scsi/scsi_sysfs.c include/scsi/scsi_device.h+4 -210 replies

Reviews trailers per patch

5 of 8 patches have a Reviewed-by or Acked-by.

PatchJohn GarryAdrian Hunter
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8
6/8R-b
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/8] Prepare for constifying SCSI host templates

Hi Martin,

This patch series prepares for constifying SCSI host templates by moving the members that are not constant out of the SCSI host template. Please consider this patch series for the next merge window.

Thanks,

Bart.

Changes compared to v6:
- Rebased this patch series on top of kernel v6.1-rc1.

Changes compared to v5:
- Addressed John Garry's feedback on patch 4/7.
- Dropped the kernel/module patch and replaced it with a series of patches that rework the scsi_device_put() calls that happen from atomic context and one patch that makes scsi_device_put() synchronous.

Changes compared to v4:
- Added three additional patches: fail host creation if creating the proc directory fails, a use-after-free fix and an improvement for the kernel module unload code.

Changes compared to v3:
- Changed the 'present' counter from 8 to 32 bits.
- Fixed a bug in an error path (reported by John Garry).
- Changed EXPORT_SYMBOL() into EXPORT_SYMBOL_GPL().
- Split patch 1/3 into two patches.

Changes compared to v2:
- Optimized the show_info == NULL case.
- Added a patch that removes the code that clears the module pointer in the host template.

Changes compared to v1:
- Fix the CONFIG_SCSI_PROC_FS=n build.

Bart Van Assche (8):
scsi: esas2r: Initialize two host template members implicitly
scsi: esas2r: Introduce scsi_template_proc_dir()
scsi: core: Fail host creation if creating the proc directory fails
scsi: core: Introduce a new list for SCSI proc directory entries
scsi: core: Rework scsi_single_lun_run()
scsi: ufs: Simplify ufshcd_set_dev_pwr_mode()
scsi: core: Remove the put_device() call from scsi_device_get()
scsi: core: Release SCSI devices synchronously

 drivers/scsi/esas2r/esas2r_main.c |  19 +++--
 drivers/scsi/hosts.c              |   3 +-
 drivers/scsi/scsi.c               |  12 +--
 drivers/scsi/scsi_lib.c           |  32 ++++---
 drivers/scsi/scsi_priv.h          |   6 +-
 drivers/scsi/scsi_proc.c          | 137 +++++++++++++++++++++++++-----
 drivers/scsi/scsi_sysfs.c         |  22 +----
 drivers/ufs/core/ufshcd.c         |   9 +-
 include/scsi/scsi_device.h        |   1 -
 include/scsi/scsi_host.h          |  18 ++--
 10 files changed, 164 insertions(+), 95 deletions(-)