Skip to content

Add core wide metric literal

Ian Rogers linux-perf-users lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 3 repliesIn review
  2. v18 patches 11 repliesApplied

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7perf metric: Return early if no CPU PMU table existstools/perf/util/metricgroup.c+3 -00 replies
2/7perf expr: Move the scanner_ctx into the parse_ctxtools/perf/tests/expr.c tools/perf/util/expr.c tools/perf/util/expr.h +2 more+11 -140 replies
3/7perf smt: Compute SMT from topologytools/perf/tests/expr.c tools/perf/util/cputopo.c tools/perf/util/cputopo.h +3 more+49 -1010 replies
4/7perf topology: Add core_widetools/perf/util/cputopo.c tools/perf/util/cputopo.h tools/perf/util/smt.c +1 more+70 -03 replies
5/7perf stat: Delay metric parsingtools/perf/builtin-stat.c tools/perf/util/metricgroup.c tools/perf/util/metricgroup.h+39 -180 replies
6/7perf metrics: Wire up core_widetools/perf/builtin-stat.c tools/perf/util/expr.c tools/perf/util/expr.h +5 more+134 -430 replies
7/7perf test: Add basic core_wide expression testtools/perf/tests/expr.c+13 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/7] Add core wide metric literal

It is possible to optimize metrics when all SMT threads (CPUs) on a core are measuring events in system wide mode. For example, TMA metrics [1] defines CORE_CLKS for Sandybrdige as:

if SMT is disabled:
CPU_CLK_UNHALTED.THREAD
if SMT is enabled and recording on all SMT threads (for all processes):
CPU_CLK_UNHALTED.THREAD_ANY / 2
if SMT is enabled and not recording on all SMT threads:
(CPU_CLK_UNHALTED.THREAD/2)* (1+CPU_CLK_UNHALTED.ONE_THREAD_ACTIVE/CPU_CLK_UNHALTED.REF_XCLK )

That is two more events are necessary when not gathering counts on all SMT threads. To distinguish all SMT threads on a core vs system wide (all CPUs) call the new property core wide.

As this literal requires the user requested CPUs and system wide to be present, the parsing of metrics is delayed until after command line option processing. As events are used to compute the evlist maps, and metrics create events, the data for core wide must come from the target.

This patch series doesn't correct the Intel metrics to use #core_wide, which will be done in follow up work. To see the two behaviors currently you need an Intel CPU between Sandybridge and before Icelake, then compare the events for tma_backend_bound_percent and Backend_Bound_SMT where the former assumes recording on all SMT threads and the latter assumes not recording on all SMT threads. The future work will just have a single backend bound metric for both cases determined using #core_wide.

[1] https://download.01.org/perfmon/TMA_Metrics.xlsx Note, #EBS_Mode is false when recording on all SMT threads and all processes which is #core_wide true in this change.

v2. Add error handling for ENOMEM to more strdup cases as suggested by
Arnaldo. Init the shadow stats if running "perf stat report", issue caught by the stat shell test.

Ian Rogers (7):
perf metric: Return early if no CPU PMU table exists perf expr: Move the scanner_ctx into the parse_ctx perf smt: Compute SMT from topology
perf topology: Add core_wide
perf stat: Delay metric parsing
perf metrics: Wire up core_wide
perf test: Add basic core_wide expression test

 tools/perf/builtin-stat.c     |  66 +++++++++++++----
 tools/perf/tests/expr.c       |  37 +++++++---
 tools/perf/util/cputopo.c     |  61 +++++++++++++++
 tools/perf/util/cputopo.h     |   5 ++
 tools/perf/util/expr.c        |  29 +++++---
 tools/perf/util/expr.h        |  14 ++--
 tools/perf/util/expr.l        |   6 +-
 tools/perf/util/metricgroup.c | 135 ++++++++++++++++++++++++----------
 tools/perf/util/metricgroup.h |   4 +-
 tools/perf/util/smt.c         | 109 ++++++---------------------
 tools/perf/util/smt.h         |  12 ++-
 tools/perf/util/stat-shadow.c |  13 +++-
 tools/perf/util/stat.h        |   2 +
 13 files changed, 318 insertions(+), 175 deletions(-)
Signature · 1 line
2.37.2.672.g94769d06f0-goog