KVM: arm64: Parallel stage-2 fault handling
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest14 patches 37 repliesIn review
- v414 patches 2 repliesSuperseded
- v315 patches 8 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 15 patches | 11 replies | Superseded | |
| v1 | 14 patches | 17 replies | Superseded |
Changes in v5 from the cover letter
- Fix an obvious leak of table memory (Ricardo)
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/14 | KVM: arm64: Combine visitor arguments into a context structurearch/ arch/ arch/ +1 more | +154 | 5 replies | |
| 2/14 | KVM: arm64: Stash observed pte value in visitor contextarch/ arch/ arch/ +1 more | +48 | 2 replies | |
| 3/14 | KVM: arm64: Pass mm_ops through the visitor contextarch/ arch/ arch/ | +26 | 3 replies | |
| 4/14 | KVM: arm64: Don't pass kvm_pgtable through kvm_pgtable_walk_dataarch/ | +5 | 3 replies | |
| 5/14 | KVM: arm64: Add a helper to tear down unlinked stage-2 subtreesarch/ arch/ | +34 | 2 replies | |
| 6/14 | KVM: arm64: Use an opaque type for ptepsarch/ arch/ arch/ | +23 | 1 reply | |
| 7/14 | KVM: arm64: Tear down unlinked stage-2 subtree after break-before-makearch/ arch/ arch/ +1 more | +39 | 1 reply | |
| 8/14 | KVM: arm64: Protect stage-2 traversal with RCUarch/ arch/ arch/ | +71 | 10 replies | |
| 9/14 | KVM: arm64: Atomically update stage 2 leaf attributes in parallel walksarch/ | +22 | 4 replies | |
| 10/14 | KVM: arm64: Split init and set for table PTEarch/ | +10 | 2 replies | |
| 11/14 | KVM: arm64: Make block->table PTE changes parallel-awarearch/ | +75 | 2 replies | |
| 12/14 | KVM: arm64: Make leaf->leaf PTE changes parallel-awarearch/ | +12 | 1 reply | |
| 13/14 | KVM: arm64: Make table->block changes parallel-awarearch/ | +3 | 0 replies | |
| 14/14 | KVM: arm64: Handle stage-2 faults in parallelarch/ arch/ arch/ +1 more | +13 | 0 replies |
Reviews trailers per patch
6 of 14 patches have a Reviewed-by or Acked-by.
| Patch | Ben Gardon | Gavin Shan |
|---|---|---|
| 1/14 | R-b | R-b |
| 2/14 | R-b | R-b |
| 3/14 | R-b | R-b |
| 4/14 | R-b | R-b |
| 5/14 | ||
| 6/14 | ||
| 7/14 | R-b | |
| 8/14 | ||
| 9/14 | ||
| 10/14 | ||
| 11/14 | ||
| 12/14 | R-b | |
| 13/14 | ||
| 14/14 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 00/14] KVM: arm64: Parallel stage-2 fault handling
Presently KVM only takes a read lock for stage 2 faults if it believes the fault can be fixed by relaxing permissions on a PTE (write unprotect for dirty logging). Otherwise, stage 2 faults grab the write lock, which predictably can pile up all the vCPUs in a sufficiently large VM.
Like the TDP MMU for x86, this series loosens the locking around manipulations of the stage 2 page tables to allow parallel faults. RCU and atomics are exploited to safely build/destroy the stage 2 page tables in light of multiple software observers.
Patches 1-4 clean up the context associated with a page table walk / PTE visit. This is helpful for:
- Extending the context passed through for a visit
- Building page table walkers that operate outside of a kvm_pgtable context (e.g. RCU callback)
Patches 5-7 clean up the stage-2 map walkers by calling a helper to tear down removed tables. There is a small improvement here in that a broken PTE is replaced more quickly, as page table teardown happens afterwards.
Patch 8 sprinkles in RCU to the page table walkers, punting the teardown of removed tables to an RCU callback.
Patches 9-13 implement the meat of this series, extending the 'break-before-make' sequence with atomics to realize locking on PTEs. Effectively a cmpxchg() is used to 'break' a PTE, thereby serializing changes to a given PTE.
Finally, patch 14 flips the switch on all the new code and starts grabbing the read side of the MMU lock for stage 2 faults.
Applies to 6.1-rc3. Tested with KVM selftests, kvm-unit-tests, and live migrating a 24 vCPU, 96GB VM that was running a Debian install. Confirmed all stage-2 table memory was freed by checking the SecPageTables stat in meminfo.
Branch available at:
https://github.com/oupton/linux kvm-arm64/parallel_mmu
benchmarked with dirty_log_perf_test, scaling from 1 to 48 vCPUs with 4GB of memory per vCPU backed by THP.
./dirty_log_perf_test -s anonymous_thp -m 2 -b 4G -v ${NR_VCPUS}Time to dirty memory:
+-------+----------+-------------------+
| vCPUs | 6.1-rc3 | 6.1-rc3 + series |
+-------+----------+-------------------+
| 1 | 0.87s | 0.93s |
| 2 | 1.11s | 1.16s |
| 4 | 2.39s | 1.27s |
| 8 | 5.01s | 1.39s |
| 16 | 8.89s | 2.07s |
| 32 | 19.90s | 4.45s |
| 48 | 32.10s | 6.23s |
+-------+----------+-------------------+It is also worth mentioning that the time to populate memory has improved:
+-------+----------+-------------------+
| vCPUs | 6.1-rc3 | 6.1-rc3 + series |
+-------+----------+-------------------+
| 1 | 0.21s | 0.17s |
| 2 | 0.26s | 0.23s |
| 4 | 0.39s | 0.31s |
| 8 | 0.68s | 0.39s |
| 16 | 1.26s | 0.53s |
| 32 | 2.51s | 1.04s |
| 48 | 3.94s | 1.55s |
+-------+----------+-------------------+v4 -> v5:
- Fix an obvious leak of table memory (Ricardo)
v3 -> v4:
- Fix some type conversion misses caught by sparse (test robot)
- Squash RCU locking and RCU callback patches together into one (Sean)
- Commit message nits (Sean)
- Take a pointer to kvm_s2_mmu in stage2_try_break_pte(), in anticipation of eager page splitting (Ricardo)
v3: https://lore.kernel.org/kvmarm/[email protected]/
v4: https://lore.kernel.org/kvmarm/[email protected]/
Oliver Upton (14):
KVM: arm64: Combine visitor arguments into a context structure
KVM: arm64: Stash observed pte value in visitor context
KVM: arm64: Pass mm_ops through the visitor context
KVM: arm64: Don't pass kvm_pgtable through kvm_pgtable_walk_data
KVM: arm64: Add a helper to tear down unlinked stage-2 subtrees
KVM: arm64: Use an opaque type for pteps
KVM: arm64: Tear down unlinked stage-2 subtree after break-before-make
KVM: arm64: Protect stage-2 traversal with RCU
KVM: arm64: Atomically update stage 2 leaf attributes in parallel
walks
KVM: arm64: Split init and set for table PTE
KVM: arm64: Make block->table PTE changes parallel-aware
KVM: arm64: Make leaf->leaf PTE changes parallel-aware
KVM: arm64: Make table->block changes parallel-aware
KVM: arm64: Handle stage-2 faults in parallel
arch/arm64/include/asm/kvm_pgtable.h | 92 +++- arch/arm64/kvm/hyp/nvhe/mem_protect.c | 21 +- arch/arm64/kvm/hyp/nvhe/setup.c | 22 +- arch/arm64/kvm/hyp/pgtable.c | 628 ++++++++++++++------------ arch/arm64/kvm/mmu.c | 53 ++- 5 files changed, 466 insertions(+), 350 deletions(-)
base-commit: 30a0b95b1335e12efef89dd78518ed3e4a71a763
Signature · 1 line
2.38.1.431.g37b22c650d-goog