Skip to content

test queue count changes on reconnect

Daniel Wagner linux-block linux-nvme 6 versions – Applied

Status from this message: I've applied this series with the edits. Thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest2 patches 5 repliesApplied
  2. v54 patches 9 repliesSuperseded
  3. v41 patch 0 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v31 patch10 repliesSuperseded
v21 patch3 repliesSuperseded
v11 patch2 repliesSuperseded

Changes in v6 from the cover letter

- moved generic rc bits back into test case
- added checks to fail early
- added timeout values parser for connect call
- reduced timeouts (runtime reduction for good and bad case)
- fixed shellcheck warnings

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/2nvme/rc: Add timeout argument parsing to _nvme_connect_subsys()tests/nvme/rc+24 -00 replies
2/2nvme/048: test queue count changes on reconnecttests/nvme/048 tests/nvme/048.out+128 -02 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [PATCH blktests v6 0/2] test queue count changes on reconnect

The target is allowed to change the number of i/o queues. Test if the host is able to reconnect in this scenario.

I've incorperated Chaitanya's feedback and also optimized the runtime for the good and the bad case (rdma started to fail today, something to fix). Before it run for rougly 25 seconds when everytying was okay.

# nvme_trtype=rdma ./check nvme/048
nvme/048 (Test queue count changes on reconnect) [failed]
runtime 6.488s ... 6.404s
--- tests/nvme/048.out 2023-04-06 09:38:29.574194562 +0200
+++ /home/wagi/work/blktests/results/nodev/nvme/048.out.bad 2023-04-06 10:09:47.692036702 +0200 @@ -1,3 +1,11 @@
Running nvme/048
-NQN:blktests-subsystem-1 disconnected 1 controller(s)
+grep: /sys/class/nvme-fabrics/ctl//state: No such file or directory
+grep: /sys/class/nvme-fabrics/ctl//state: No such file or directory
+grep: /sys/class/nvme-fabrics/ctl//state: No such file or directory
+grep: /sys/class/nvme-fabrics/ctl//state: No such file or directory
+grep: /sys/class/nvme-fabrics/ctl//state: No such file or directory
...
(Run 'diff -u tests/nvme/048.out /home/wagi/work/blktests/results/nodev/nvme/048.out.bad' to see the entire diff)
# nvme_trtype=tcp ./check nvme/048
nvme/048 (Test queue count changes on reconnect) [passed]

      runtime  6.350s  ...  6.227s

This version is based on my previous posted nvme/047 patches [1]

[1] https://lore.kernel.org/linux-nvme/[email protected]/

v6:
- moved generic rc bits back into test case
- added checks to fail early
- added timeout values parser for connect call
- reduced timeouts (runtime reduction for good and bad case)
- fixed shellcheck warnings
v5:
- moved generic parts to nvme/rc
- renamed test to 048
- rebased ontop of nvme/047
- https://lore.kernel.org/linux-nvme/[email protected]/
v4:
- do not remove ports instead depend on host removing controllers, see
https://lore.kernel.org/linux-nvme/[email protected]/
- https://lore.kernel.org/linux-nvme/[email protected]/
v3:
- Added comment why at least 2 CPUs are needed for the test
- Fixed shell quoting in _set_nvmet_attr_qid_max
- https://lore.kernel.org/linux-nvme/[email protected]/
v2:
- detect if attr_qid_max is available
- https://lore.kernel.org/linux-block/[email protected]/
v1:
- https://lore.kernel.org/linux-block/[email protected]/

Daniel Wagner (2):
nvme/rc: Add timeout argument parsing to _nvme_connect_subsys() nvme/048: test queue count changes on reconnect

 tests/nvme/048     | 125 +++++++++++++++++++++++++++++++++++++++++++++
 tests/nvme/048.out |   3 ++
 tests/nvme/rc      |  24 +++++++++
 3 files changed, 152 insertions(+)
 create mode 100755 tests/nvme/048
 create mode 100644 tests/nvme/048.out
Signature · 1 line
2.40.0