Skip to content

Add sample_flags to improve the perf_sample_data struct

[email protected] bpf lkml 2 versions – Applied

Status from this message: The following commit has been merged into the perf/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 8 repliesApplied
  2. v16 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- Update the AMD LBR code in patch 3

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/6perf: Add sample_flags to indicate the PMU-filled sample datainclude/linux/perf_event.h kernel/events/core.c+13 -60 replies
2/6perf/x86/intel/pebs: Fix PEBS timestamps overwrittenarch/x86/events/intel/ds.c+6 -23 replies
3/6perf: Use sample_flags for branch stackarch/powerpc/perf/core-book3s.c arch/x86/events/amd/core.c arch/x86/events/core.c +4 more+18 -81 reply
4/6perf: Use sample_flags for weightarch/powerpc/perf/core-book3s.c arch/x86/events/intel/ds.c include/linux/perf_event.h +1 more+14 -72 replies
5/6perf: Use sample_flags for data_srcarch/powerpc/perf/core-book3s.c arch/x86/events/intel/ds.c include/linux/perf_event.h +1 more+13 -50 replies
6/6perf: Use sample_flags for txnarch/x86/events/intel/ds.c include/linux/perf_event.h kernel/events/core.c+10 -40 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchNamhyung Kim
SeriesA-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH V2 0/6] Add sample_flags to improve the perf_sample_data struct

From: Kan Liang <[email protected]>

Changes since V1:
- Update the AMD LBR code in patch 3

The patch series is to fix PEBS timestamps overwritten and improve the perf_sample_data struct. The detailed discussion can be found at
https://lore.kernel.org/lkml/YwXvGe4%[email protected]/

The patch series has two changes compared with the suggestions in the above discussion.
- Only clear the sample flags for the perf_prepare_sample(). The __perf_event_header__init_id is shared between perf_prepare_sample() (used by PERF_RECORD_SAMPLE) and perf_event_header__init_id() (used by other PERF_RECORD_* event type). The sample data is only available for the PERF_RECORD_SAMPLE.
- The CALLCHAIN_EARLY hack is still required for the BPF, especially perf_event_set_bpf_handler(). The sample data is not available when the function is invoked.

Kan Liang (6):
perf: Add sample_flags to indicate the PMU-filled sample data perf/x86/intel/pebs: Fix PEBS timestamps overwritten
perf: Use sample_flags for branch stack
perf: Use sample_flags for weight
perf: Use sample_flags for data_src
perf: Use sample_flags for txn

 arch/powerpc/perf/core-book3s.c | 10 ++++++---
 arch/x86/events/amd/core.c      |  4 +++-
 arch/x86/events/core.c          |  4 +++-
 arch/x86/events/intel/core.c    |  4 +++-
 arch/x86/events/intel/ds.c      | 39 ++++++++++++++++++++++++---------
 include/linux/perf_event.h      | 15 ++++++-------
 kernel/events/core.c            | 30 ++++++++++++++++++-------
 7 files changed, 74 insertions(+), 32 deletions(-)
Signature · 1 line
2.35.1