PCI/PM: Always disable PTM for all devices during suspend
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest9 patches 8 repliesIn review
- v310 patches 11 repliesSuperseded
- v23 patches 6 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 4 patches | 6 replies | Superseded |
Changes in v4 from the cover letter
- Use u16 for ptm_cap
- Add kernel-doc for pci_enable_ptm() and pci_disable_ptm() (exported functions)
- Drop "Preserve PTM Root Select" (unnecessary since enabling PTM sets Root Select when needed)
- Squash these three patches into one because they make more sense that way:
PCI/PTM: Add suspend/resume
PCI/PTM: Add pci_enable_ptm() wrapper
PCI/PTM: Add pci_disable_ptm() wrapper
- Add "PCI/PTM: Preserve RsvdP bits in PTM Control register"
- Add "PCI/PTM: Consolidate PTM interface declarations"
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | PCI/PTM: Cache PTM Capability offsetdrivers/ include/ | +18 | 1 reply | |
| 2/9 | PCI/PTM: Add pci_upstream_ptm() helperdrivers/ | +25 | 1 reply | |
| 3/9 | PCI/PTM: Separate configuration and enabledrivers/ | +49 | 0 replies | |
| 4/9 | PCI/PTM: Add pci_suspend_ptm() and pci_resume_ptm()drivers/ drivers/ drivers/ +1 more | +65 | 1 reply | |
| 5/9 | PCI/PTM: Move pci_ptm_info() body into its only callerdrivers/ | +17 | 1 reply | |
| 6/9 | PCI/PTM: Preserve RsvdP bits in PTM Control registerdrivers/ | +14 | 1 reply | |
| 7/9 | PCI/PTM: Reorder functions in logical orderdrivers/ | +62 | 0 replies | |
| 8/9 | PCI/PTM: Consolidate PTM interface declarationsdrivers/ | +2 | 0 replies | |
| 9/9 | PCI/PM: Always disable PTM for all devices during suspenddrivers/ drivers/ | +13 | 0 replies |
Reviews trailers per patch
4 of 9 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Kuppuswamy Sathyanarayanan | Mika Westerberg |
|---|---|---|
| Series | R-b | |
| 1/9 | R-b | |
| 2/9 | R-b | |
| 3/9 | ||
| 4/9 | ||
| 5/9 | R-b | |
| 6/9 | R-b | |
| 7/9 | ||
| 8/9 | ||
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/9] PCI/PM: Always disable PTM for all devices during suspend
From: Bjorn Helgaas <[email protected]>
We currently disable PTM for Root Ports during suspend. Leaving PTM enabled for downstream devices causes UR errors if they send PTM Requests to upstream devices that have PTM disabled.
The intent of this series is to:
- Unconditionally disable PTM during suspend (even if the driver saves its own state) by moving the disable from pci_prepare_to_sleep() to pci_pm_suspend().
- Disable PTM for all devices by removing the Root Port condition and doing it early in the suspend paths.
- Explicitly re-enable PTM during resume.
Changes between v3 and v4:
- Use u16 for ptm_cap
- Add kernel-doc for pci_enable_ptm() and pci_disable_ptm() (exported functions)
- Drop "Preserve PTM Root Select" (unnecessary since enabling PTM sets Root Select when needed)
- Squash these three patches into one because they make more sense that way:
PCI/PTM: Add suspend/resume
PCI/PTM: Add pci_enable_ptm() wrapper
PCI/PTM: Add pci_disable_ptm() wrapper
- Add "PCI/PTM: Preserve RsvdP bits in PTM Control register"
- Add "PCI/PTM: Consolidate PTM interface declarations"
Bjorn Helgaas (9):
PCI/PTM: Cache PTM Capability offset
PCI/PTM: Add pci_upstream_ptm() helper
PCI/PTM: Separate configuration and enable PCI/PTM: Add pci_suspend_ptm() and pci_resume_ptm() PCI/PTM: Move pci_ptm_info() body into its only caller PCI/PTM: Preserve RsvdP bits in PTM Control register PCI/PTM: Reorder functions in logical order PCI/PTM: Consolidate PTM interface declarations PCI/PM: Always disable PTM for all devices during suspend
drivers/pci/pci-driver.c | 11 ++ drivers/pci/pci.c | 28 +-- drivers/pci/pci.h | 14 +- drivers/pci/pcie/ptm.c | 384 +++++++++++++++++++++------------------ include/linux/pci.h | 3 + 5 files changed, 234 insertions(+), 206 deletions(-)
Signature · 1 line
2.25.1