Skip to content

bpftool: Add LLVM as default library for disassembling JIT-ed programs

Quentin Monnet bpf 4 versions – Applied

Status from this message: This series was applied to bpf/bpf-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest8 patches 0 repliesApplied 8/8
  2. v38 patches 6 repliesSuperseded
  3. v28 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v17 patches16 repliesSuperseded

Changes in v4 from the cover letter

- Rebase to address a conflict with commit 2c76238eaddd ("bpftool: Add "bootstrap" feature to version output").

Patches in v4 All 8 applied

#Subject and filesSizeRepliesApplied
1/8bpftool: Define _GNU_SOURCE only oncetools/bpf/bpftool/common.c tools/bpf/bpftool/iter.c tools/bpf/bpftool/jit_disasm.c +4 more+14 -00 repliesApplied
2/8bpftool: Remove asserts from JIT disassemblertools/bpf/bpftool/jit_disasm.c tools/bpf/bpftool/main.h tools/bpf/bpftool/map.c +1 more+57 -350 repliesApplied
3/8bpftool: Split FEATURE_TESTS/FEATURE_DISPLAY definitions in Makefiletools/bpf/bpftool/Makefile+14 -50 repliesApplied
4/8bpftool: Group libbfd defs in Makefile, only pass them if we use libbfdtools/bpf/bpftool/Makefile+15 -120 repliesApplied
5/8bpftool: Refactor disassembler for JIT-ed programstools/bpf/bpftool/jit_disasm.c+88 -450 repliesApplied
6/8bpftool: Add LLVM as default library for disassembling JIT-ed programstools/bpf/bpftool/Makefile tools/bpf/bpftool/jit_disasm.c tools/bpf/bpftool/main.h+140 -220 repliesApplied
7/8bpftool: Support setting alternative arch for JIT disasm with LLVMtools/bpf/bpftool/common.c tools/bpf/bpftool/jit_disasm.c tools/bpf/bpftool/main.h +1 more+16 -180 repliesApplied
8/8bpftool: Add llvm feature to "bpftool version"tools/bpf/bpftool/Documentation/common_options.rst tools/bpf/bpftool/main.c+11 -40 repliesApplied

Reviews trailers per patch

7 of 8 patches have a Reviewed-by or Acked-by.

PatchNiklas SöderlundSong LiuYonghong Song
1/8T-b A-b
2/8T-b A-b
3/8T-b A-b
4/8T-b A-b
5/8T-b A-b
6/8T-b A-b
7/8
8/8T-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH bpf-next v4 0/8] bpftool: Add LLVM as default library for disassembling JIT-ed programs

To disassemble instructions for JIT-ed programs, bpftool has relied on the libbfd library. This has been problematic in the past: libbfd's interface is not meant to be stable and has changed several times, hence the detection of the two related features from the Makefile (disassembler-four-args and disassembler-init-styled). When it comes to shipping bpftool, this has also caused issues with several distribution maintainers unwilling to support the feature (for example, Debian's page for binutils-dev, libbfd's package, says: "Note that building Debian packages which depend on the shared libbfd is Not Allowed.").

This patchset adds support for LLVM as the primary library for disassembling instructions for JIT-ed programs.

We keep libbfd as a fallback. One reason for this is that currently it works well, we have all we need in terms of features detection in the Makefile, so it provides a fallback for disassembling JIT-ed programs if libbfd is installed but LLVM is not. The other reason is that libbfd supports nfp instruction for Netronome's SmartNICs and can be used to disassemble offloaded programs, something that LLVM cannot do (Niklas confirmed that the feature is still in use). However, if libbfd's interface breaks again in the future, we might reconsider keeping support for it.

v4:
- Rebase to address a conflict with commit 2c76238eaddd ("bpftool: Add "bootstrap" feature to version output").

v3:
- Extend commit description (patch 6) with notes on llvm-dev and LLVM's disassembler stability.

v2:
- Pass callback when creating the LLVM disassembler, so that the branch targets are printed as addresses (instead of byte offsets).
- Add last commit to "support" other arch with LLVM, although we don't know any supported triple yet.
- Use $(LLVM_CONFIG) instead of llvm-config in Makefile.
- Pass components to llvm-config --libs to limit the number of libraries to pass on the command line, in Makefile.
- Rebase split of FEATURE_TESTS and FEATURE_DISPLAY in Makefile.

Quentin Monnet (8):
bpftool: Define _GNU_SOURCE only once
bpftool: Remove asserts from JIT disassembler
bpftool: Split FEATURE_TESTS/FEATURE_DISPLAY definitions in Makefile
bpftool: Group libbfd defs in Makefile, only pass them if we use
libbfd
bpftool: Refactor disassembler for JIT-ed programs
bpftool: Add LLVM as default library for disassembling JIT-ed programs
bpftool: Support setting alternative arch for JIT disasm with LLVM
bpftool: Add llvm feature to "bpftool version"

 .../bpftool/Documentation/common_options.rst  |   8 +-
 tools/bpf/bpftool/Makefile                    |  72 +++--
 tools/bpf/bpftool/common.c                    |  12 +-
 tools/bpf/bpftool/iter.c                      |   2 +
 tools/bpf/bpftool/jit_disasm.c                | 261 +++++++++++++++---
 tools/bpf/bpftool/main.c                      |   7 +
 tools/bpf/bpftool/main.h                      |  32 +--
 tools/bpf/bpftool/map.c                       |   1 -
 tools/bpf/bpftool/net.c                       |   2 +
 tools/bpf/bpftool/perf.c                      |   2 +
 tools/bpf/bpftool/prog.c                      |  23 +-
 tools/bpf/bpftool/xlated_dumper.c             |   2 +
 12 files changed, 319 insertions(+), 105 deletions(-)
Signature · 1 line
2.34.1