Skip to content

drm/panel: Add Samsung AMS495QA01 Panel

Chris Morgan dri-devel linux-devicetree linux-rockchip 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 7 repliesIn review
  2. v32 patches 1 replySuperseded
  3. v22 patches 4 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches2 repliesSuperseded

Changes in v4 from the cover letter

- Updated documentation to add spi-peripheral-props.yaml per updates
made for similar devices. Note that I removed a "Reviewed-by" tag
from Rob Herring since this change probably needs to be confirmed.
- Added binding for RG503, since this device is now accepted with this
request: https://lore.kernel.org/linux-rockchip/[email protected]/

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3dt-bindings: display: panel: Add Samsung AMS495QA01Documentation/devicetree/bindings/display/panel/samsung,ams495qa01.yaml+57 -02 replies
2/3drm/panel: Add Samsung AMS495QA01 MIPI-DSI LCD paneldrivers/gpu/drm/panel/Kconfig drivers/gpu/drm/panel/Makefile drivers/gpu/drm/panel/panel-samsung-ams495qa01.c+558 -05 replies
3/3arm64: dts: rockchip: add display to RG503arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg503.dts+61 -00 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchRob HerringLinus Walleij
1/3R-b R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH V4 0/3] drm/panel: Add Samsung AMS495QA01 Panel

From: Chris Morgan <[email protected]>

Add the Samsung AMS495QA01 panel as found on the Anbernic RG503. This panel uses DSI to receive video signals, but 3-wire SPI to receive command signals.

Changes since V3:
- Updated documentation to add spi-peripheral-props.yaml per updates
made for similar devices. Note that I removed a "Reviewed-by" tag
from Rob Herring since this change probably needs to be confirmed.
- Added binding for RG503, since this device is now accepted with this
request: https://lore.kernel.org/linux-rockchip/[email protected]/

Changes since V2:
- Added 50hz mode at request of userspace devs.
- Renamed "dupa" to panel name. Good catch Maya.
- Added Maya's Signed-off-by.
- Removed check for max backlight, since it is already done by backlight_device_set_brightness.
- Fixed minor formatting issues on devicetree binding documentation and added port to provided example.

Changes since V1:
- Removed errant reference to backlight in documentation. This is an OLED panel.
- Made elvss regulator optional. In my case its hard wired and not controllable.
- Added "prepared" enum to track panel status to prevent unbalanced regulator enable/disable.

Chris Morgan (3):
dt-bindings: display: panel: Add Samsung AMS495QA01 drm/panel: Add Samsung AMS495QA01 MIPI-DSI LCD panel
arm64: dts: rockchip: add display to RG503

 .../display/panel/samsung,ams495qa01.yaml     |  57 ++
 .../dts/rockchip/rk3566-anbernic-rg503.dts    |  61 ++
 drivers/gpu/drm/panel/Kconfig                 |  10 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 .../gpu/drm/panel/panel-samsung-ams495qa01.c  | 547 ++++++++++++++++++
 5 files changed, 676 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,ams495qa01.yaml
 create mode 100644 drivers/gpu/drm/panel/panel-samsung-ams495qa01.c
Signature · 1 line
2.25.1