Skip to content

RDMA/mlx5: Switch MR cache to use RB-tree

Michael Guralnik linux-rdma 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8RDMA/mlx5: Don't keep umrable 'page_shift' in cache entriesdrivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/mr.c drivers/infiniband/hw/mlx5/odp.c+1 -50 replies
2/8RDMA/mlx5: Generalize mlx5_cache_cache_mr() to fit all cacheable mkeysdrivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/mr.c drivers/infiniband/hw/mlx5/odp.c+87 -741 reply
3/8RDMA/mlx5: Remove explicit ODP cache entrydrivers/infiniband/hw/mlx5/odp.c include/linux/mlx5/driver.h+2 -150 replies
4/8RDMA/mlx5: Allow rereg all the mkeys that can load pas with UMRdrivers/infiniband/hw/mlx5/mr.c+2 -50 replies
5/8RDMA/mlx5: Introduce mlx5r_cache_rb_keydrivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/mr.c drivers/infiniband/hw/mlx5/odp.c+69 -260 replies
6/8RDMA/mlx5: Change the cache structure to an RB-treedrivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/mr.c drivers/infiniband/hw/mlx5/odp.c+223 -960 replies
7/8RDMA/mlx5: Cache all user cacheable mkeys on dereg MR flowdrivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/mr.c+42 -80 replies
8/8RDMA/mlx5: Add work to remove temporary entries from the cachedrivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/mr.c+83 -140 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchMichael Guralnik
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH rdma-next 0/8] RDMA/mlx5: Switch MR cache to use RB-tree

This series moves the MR cache to use RB tree to store the entries of the cache. By doing so, enabling more flexibility when managing the cache entries.

The MR cache will now cache mkeys returned by the user even if they are not from one of the predefined pools, by that allowing restarting applications to reuse the their released mkey and improve restart times.

Aharon Landau (8):
RDMA/mlx5: Don't keep umrable 'page_shift' in cache entries RDMA/mlx5: Generalize mlx5_cache_cache_mr() to fit all cacheable mkeys RDMA/mlx5: Remove explicit ODP cache entry
RDMA/mlx5: Allow rereg all the mkeys that can load pas with UMR RDMA/mlx5: Introduce mlx5r_cache_rb_key
RDMA/mlx5: Change the cache structure to an RB-tree RDMA/mlx5: Cache all user cacheable mkeys on dereg MR flow RDMA/mlx5: Add work to remove temporary entries from the cache

 drivers/infiniband/hw/mlx5/mlx5_ib.h |  42 +-
 drivers/infiniband/hw/mlx5/mr.c      | 559 +++++++++++++++++++--------
 drivers/infiniband/hw/mlx5/odp.c     |  34 +-
 include/linux/mlx5/driver.h          |   1 -
 4 files changed, 451 insertions(+), 185 deletions(-)
Signature · 1 line
2.17.2