Skip to content

xfsrestore: fix inventory unpacking

Donald Douwsma linux-xfs 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 0 repliesNew
  2. v34 patches 7 repliesSuperseded
  3. v23 patches 9 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch2 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4xfsrestore: fix on-media inventory media unpackinginventory/inv_stobj.c+7 -200 replies
2/4xfsrestore: fix on-media inventory stream unpackinginventory/inv_stobj.c+7 -60 replies
3/4xfsdump: fix on-media inventory stream packinginventory/inv_stobj.c+1 -10 replies
4/4xfsrestore: untangle inventory unpacking logicrestore/content.c+5 -80 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchDarrick J. Wong
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/4] xfsrestore: fix inventory unpacking

When xfsrestore reads its inventory from tape it fails to convert the media record on bigendian systems, if the online inventory is unavailable this results in invalid data being writen to the online inventory and failure to restore non-directory files.

The series fixes the converstion and related issues.

---
v2
- Seperate out cleanup and content.c changes, fix whitespace.
- Show a full reproducer in the first patch.
V3
- Fix whitespace and Signed-off-by.
- Make for loop formatting consistent.
- Rename patches to make their intent clearer.
- Add xfsdump: fix on-media inventory stream packing.
- Add descriptions that reproduce the stream problems.
V4
- Rerun testcase in "xfsdump: fix on-media inventory stream packing" description to avoid confusion.

Donald Douwsma (4):
xfsrestore: fix on-media inventory media unpacking
xfsrestore: fix on-media inventory stream unpacking
xfsdump: fix on-media inventory stream packing
xfsrestore: untangle inventory unpacking logic

 inventory/inv_stobj.c | 42 +++++++++++++++---------------------------
 restore/content.c     | 13 +++++--------
 2 files changed, 20 insertions(+), 35 deletions(-)
Signature · 1 line
2.31.1