Skip to content

drm/arm/malidp: use drm managed resources

Danilo Krummrich dri-devel lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 2 repliesIn review
  2. v2 posting 2/29 patches 0 repliesSuperseded
  3. v2 posting 1/29 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v18 patches0 repliesSuperseded

Changes in v3 from the cover letter

- Remove patches to protect platform device bound resources with drm_dev_{enter,exit}, since this would leave the hardware enabled when regularly unloading the driver e.g. via rmmod.
Instead do this in a later series, once we got drm_dev_unplug() in place to deal with a regular driver shutdown.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5drm/arm/malidp: use drmm_* to allocate driver structuresdrivers/gpu/drm/arm/malidp_drv.c drivers/gpu/drm/arm/malidp_drv.h+8 -130 replies
2/5drm/arm/malidp: replace drm->dev_private with drm_to_malidp()drivers/gpu/drm/arm/malidp_crtc.c drivers/gpu/drm/arm/malidp_drv.c drivers/gpu/drm/arm/malidp_drv.h +3 more+25 -270 replies
3/5drm/arm/malidp: crtc: use drmm_crtc_init_with_planes()drivers/gpu/drm/arm/malidp_crtc.c+2 -30 replies
4/5drm/arm/malidp: plane: use drm managed resourcesdrivers/gpu/drm/arm/malidp_planes.c+7 -210 replies
5/5drm/arm/malidp: remove calls to drm_mode_config_cleanup()drivers/gpu/drm/arm/malidp_drv.c+6 -140 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH drm-misc-next v3 0/5] drm/arm/malidp: use drm managed resources

Hi,

This patch series converts the driver to use drm managed resources to prevent potential use-after-free issues on driver unbind/rebind and to get rid of the usage of deprecated APIs.

Changes in v2:
- While protecting critical sections with drm_dev_{enter,exit} I forgot to handle alternate return paths within the read-side critical sections, hence fix them.
- Add a patch to remove explicit calls to drm_mode_config_cleanup() and switch to drmm_mode_config_init() explicitly.

Changes in v3:
- Remove patches to protect platform device bound resources with drm_dev_{enter,exit}, since this would leave the hardware enabled when regularly unloading the driver e.g. via rmmod.
Instead do this in a later series, once we got drm_dev_unplug() in place to deal with a regular driver shutdown.

Danilo Krummrich (5):
drm/arm/malidp: use drmm_* to allocate driver structures drm/arm/malidp: replace drm->dev_private with drm_to_malidp() drm/arm/malidp: crtc: use drmm_crtc_init_with_planes() drm/arm/malidp: plane: use drm managed resources drm/arm/malidp: remove calls to drm_mode_config_cleanup()

 drivers/gpu/drm/arm/malidp_crtc.c   |  7 ++-
 drivers/gpu/drm/arm/malidp_drv.c    | 69 +++++++++++------------------
 drivers/gpu/drm/arm/malidp_drv.h    |  2 +
 drivers/gpu/drm/arm/malidp_hw.c     | 10 ++---
 drivers/gpu/drm/arm/malidp_mw.c     |  6 +--
 drivers/gpu/drm/arm/malidp_planes.c | 32 ++++---------
 6 files changed, 48 insertions(+), 78 deletions(-)

base-commit: e1e7bc481d49c3e3ada11029ce0d9b85a0a539d7

Signature · 1 line
2.37.3