Add Andes AE350 fdt driver support

Quoted 44 lines · Yu-Chien Peter Lin

Quoted 33 lines · Anup Patel

Quoted 22 lines · Yu-Chien Peter Lin

Quoted 22 lines

Quoted 5 lines

Quoted 5 lines

Applied this series to the riscv/opensbi repo.

Any thoughts on using the generic platform ?

Quoted 7 lines

Quoted 2 lines

Thanks,
Anup

Hi Anup,

The FW_TEXT_START on AE350 is different from generic platform. Will it become a configuration?

The generic platform has FW_PIC enabled so you can load and run generic firmwares from any address.

Quoted 2 lines

I think we would keep the platform specific files in andes/ae350 until we have to refactor the duplicate code.

You can add platform specific overrides to generic platforms which are selected based on compatible string in the root DT node.

Quoted 8 lines

Quoted 2 lines

Regards,
Anup

Hi Anup,

We're considering using generic platform, but I don't find any vendor_ext_provider is implemented as a platform_override hook, does it mean we need to drop it if we move to generic platform?

Quoted 8 lines

vendor_ext_provider() is available in platform_override of generic platform.

Please check the latest OpenSBI sources.

Regards,
Anup

Quoted 6 lines

Hi Anup,

Sorry, I know there is vendor_ext_provider in platform_override, except AE350, no other platforms actually have such hook in their platform specific files, so I was wondering if the current acceptance policy won't let us keep that function even in platform/andes/ae350.

We generally encourage platform vendors to prefer standard SBI extensions over custom SBI extensions but it might not be always possible to have a standard extension for everything out there.

In other words, we do expect a few platform_override to have vendor_ext_provider() for platform specific quirks and currently we are OKAY with it but platform vendor will have to maintain their vendor_ext_provider() implementation.

Regards,
Anup