Skip to content

powerpc: Syscall wrapper and register clearing

Rohan McLure linux-arch linuxppc-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest23 patches 22 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23powerpc: Remove asmlinkage from syscall handler definitionsarch/powerpc/include/asm/syscalls.h arch/powerpc/kernel/sys_ppc32.c+12 -120 replies
2/23powerpc: Save caller r3 prior to system_call_exceptionarch/powerpc/kernel/entry_32.S arch/powerpc/kernel/interrupt_64.S arch/powerpc/kernel/syscall.c+3 -10 replies
3/23powerpc: Add ZEROIZE_GPRS macros for register clearsarch/powerpc/include/asm/ppc_asm.h+22 -00 replies
4/23powerpc/64s: Use {ZEROIZE,SAVE,REST}_GPRS macros in sc, scv 0 handlersarch/powerpc/kernel/interrupt_64.S+9 -340 replies
5/23powerpc/32: Clarify interrupt restores with REST_GPR macro in entry_32.Sarch/powerpc/kernel/entry_32.S+13 -201 reply
6/23powerpc/64e: Clarify register saves and clears with {SAVE,ZEROIZE}_GPRSarch/powerpc/kernel/exceptions-64e.S+11 -161 reply
7/23powerpc/64s: Fix comment on interrupt handler prologuearch/powerpc/kernel/exceptions-64s.S+2 -21 reply
8/23powerpc: Fix fallocate and fadvise64_64 compat parameter combinationarch/powerpc/include/asm/syscalls.h arch/powerpc/kernel/sys_ppc32.c arch/powerpc/kernel/syscalls.c+15 -152 replies
9/23asm-generic: compat: Support BE for long long args in 32-bit ABIsinclude/asm-generic/compat.h+7 -22 replies
10/23powerpc: Use generic fallocate compatibility syscallarch/powerpc/include/asm/syscalls.h arch/powerpc/include/asm/unistd.h arch/powerpc/kernel/sys_ppc32.c+1 -91 reply
11/23powerpc/32: Remove powerpc select specialisationarch/powerpc/include/asm/syscalls.h arch/powerpc/kernel/syscalls.c arch/powerpc/kernel/syscalls/syscall.tbl +1 more+2 -210 replies
12/23powerpc: Remove direct call to personality syscall handlerarch/powerpc/kernel/syscalls.c+1 -10 replies
13/23powerpc: Remove direct call to mmap2 syscall handlersarch/powerpc/kernel/sys_ppc32.c arch/powerpc/kernel/syscalls.c+14 -120 replies
14/23powerpc: Provide do_ppc64_personality helperarch/powerpc/kernel/syscalls.c+5 -10 replies
15/23powerpc: Adopt SYSCALL_DEFINE for arch-specific syscall handlersarch/powerpc/include/asm/syscalls.h arch/powerpc/kernel/sys_ppc32.c arch/powerpc/kernel/syscalls.c +2 more+64 -452 replies
16/23powerpc: Include all arch-specific syscall prototypesarch/powerpc/include/asm/syscalls.h arch/powerpc/include/asm/syscalls_32.h arch/powerpc/kernel/signal_32.c +1 more+77 -241 reply
17/23powerpc: Enable compile-time check for syscall handlersarch/powerpc/kernel/systbl.c+11 -171 reply
18/23powerpc: Use common syscall handler typearch/powerpc/include/asm/syscall.h arch/powerpc/include/asm/syscalls.h arch/powerpc/kernel/systbl.c +2 more+14 -101 reply
19/23powerpc: Provide syscall wrapperarch/powerpc/Kconfig arch/powerpc/include/asm/interrupt.h arch/powerpc/include/asm/syscall.h +7 more+164 -332 replies
20/23powerpc/64s: Clear/restore caller gprs in syscall interrupt/returnarch/powerpc/kernel/interrupt_64.S+6 -34 replies
21/23powerpc/64: Add INTERRUPT_SANITIZE_REGISTERS Kconfigarch/powerpc/Kconfig+9 -01 reply
22/23powerpc/64s: Clear gprs on interrupt routine entry in Book3Sarch/powerpc/kernel/exceptions-64s.S arch/powerpc/kernel/interrupt_64.S+45 -21 reply
23/23powerpc/64e: Clear gprs on interrupt routine entry on Book3Earch/powerpc/kernel/exceptions-64e.S+7 -10 replies

Reviews trailers per patch

19 of 23 patches have a Reviewed-by or Acked-by.

PatchNicholas PigginAndrew DonnellanArnd Bergmann
1/23R-b R-b
2/23R-b
3/23R-b
4/23R-b
5/23R-b
6/23R-b
7/23R-b
8/23R-b R-b
9/23R-b R-b
10/23R-b
11/23R-b
12/23R-b
13/23R-b
14/23R-b
15/23R-b
16/23A-b
17/23R-b
18/23R-b
19/23
20/23
21/23A-b
22/23
23/23

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/23] powerpc: Syscall wrapper and register clearing

V4 available here:

Implement a syscall wrapper, causing arguments to handlers to be passed via a struct pt_regs on the stack. The syscall wrapper is implemented for all platforms other than the Cell processor, from which SPUs expect the ability to directly call syscall handler symbols with the regular in-register calling convention.

Adopting syscall wrappers requires redefinition of architecture-specific syscalls and compatibility syscalls to use the SYSCALL_DEFINE and COMPAT_SYSCALL_DEFINE macros, as well as removal of direct-references to the emitted syscall-handler symbols from within the kernel. This work lead to the following modernisations of powerpc's syscall handlers:

- Replace syscall 82 semantics with sys_old_select and remove ppc_select handler, which features direct call to both sys_old_select and sys_select.
- Use a generic fallocate compatibility syscall

Replace asm implementation of syscall table with C implementation for more compile-time checks.

Many compatibility syscalls are candidates to be removed in favour of generically defined handlers, but exhibit different parameter orderings and numberings due to 32-bit ABI support for 64-bit parameters. The parameter reorderings are however consistent with arm. A future patch series will serve to modernise syscalls by providing generic implementations featuring these reorderings.

The design of this syscall is very similar to the s390, x86 and arm64 implementations. See also Commit 4378a7d4be30 (arm64: implement syscall wrappers). The motivation for this change is that it allows for the clearing of register state when entering the kernel via through interrupt handlers on 64-bit servers. This serves to reduce the influence of values in registers carried over from the interrupted process, e.g. syscall parameters from user space, or user state at the site of a pagefault. All values in registers are saved and zeroized at the entry to an interrupt handler and restored afterward. While this may sound like a heavy-weight mitigation, many gprs are already saved and restored on handling of an interrupt, and the mmap_bench benchmark on Power 9 guest, repeatedly invoking the pagefault handler suggests at most ~0.8% regression in performance. Realistic workloads are not constantly producing interrupts, and so this does not indicate realistic slowdown.

Using wrapped syscalls yields to a performance improvement of ~5.6% on the null_syscall benchmark on pseries guests, by removing the need for system_call_exception to allocate its own stack frame. This amortises the additional costs of saving and restoring non-volatile registers (register clearing is cheap on super scalar platforms), and so the final mitigation actually yields a net performance improvement of ~0.6% on the null_syscall benchmark.

The clearing of general purpose registers on interrupts other than syscalls is enabled by default only on Book3E 64-bit systems (where the mitigation is inexpensive), but available to other 64-bit systems via the INTERRUPT_SANITIZE_REGISTERS Kconfig option. This mitigation is optional, as the speculation influence of interrupts is likely less than that of syscalls.

Patch Changelog:

- Format orig_r3 handling as its own patch rather than just a revert.
- Provide asm-generic BE implementation of long-long munging syscall compatiblity arguments.
- Syscall #82 now refers to generic sys_old_select or comptat_sys_old_select.
- Drop 'inline' on static helper functions for mmap, personality.
- Remove arch-specific sys fallocate implementation that was meant to have been removed in V2.
- Remove references to syscall wrapper until it is introduced.
- Rearrange patch series so the last five patches are syscall wrapper > syscall register clears > interrupt register clears.
- Whether non-syscall interrupts should clear registers is now configurable by INTERRUPT_SANITIZE_REGISTERS.

Rohan McLure (23):
powerpc: Remove asmlinkage from syscall handler definitions
powerpc: Save caller r3 prior to system_call_exception
powerpc: Add ZEROIZE_GPRS macros for register clears powerpc/64s: Use {ZEROIZE,SAVE,REST}_GPRS macros in sc, scv 0 handlers powerpc/32: Clarify interrupt restores with REST_GPR macro in

    entry_32.S

powerpc/64e: Clarify register saves and clears with
{SAVE,ZEROIZE}_GPRS
powerpc/64s: Fix comment on interrupt handler prologue
powerpc: Fix fallocate and fadvise64_64 compat parameter combination
asm-generic: compat: Support BE for long long args in 32-bit ABIs
powerpc: Use generic fallocate compatibility syscall powerpc/32: Remove powerpc select specialisation
powerpc: Remove direct call to personality syscall handler
powerpc: Remove direct call to mmap2 syscall handlers
powerpc: Provide do_ppc64_personality helper
powerpc: Adopt SYSCALL_DEFINE for arch-specific syscall handlers
powerpc: Include all arch-specific syscall prototypes
powerpc: Enable compile-time check for syscall handlers
powerpc: Use common syscall handler type
powerpc: Provide syscall wrapper
powerpc/64s: Clear/restore caller gprs in syscall interrupt/return powerpc/64: Add INTERRUPT_SANITIZE_REGISTERS Kconfig powerpc/64s: Clear gprs on interrupt routine entry in Book3S powerpc/64e: Clear gprs on interrupt routine entry on Book3E

 arch/powerpc/Kconfig                         |  10 ++
 arch/powerpc/include/asm/interrupt.h         |   3 +-
 arch/powerpc/include/asm/ppc_asm.h           |  22 +++
 arch/powerpc/include/asm/syscall.h           |  11 +-
 arch/powerpc/include/asm/syscall_wrapper.h   |  84 ++++++++++
 arch/powerpc/include/asm/syscalls.h          | 148 +++++++++++++----
 .../ppc32.h => include/asm/syscalls_32.h}    |   0
 arch/powerpc/include/asm/unistd.h            |   1 +
 arch/powerpc/kernel/entry_32.S               |  40 ++---
 arch/powerpc/kernel/exceptions-64e.S         |  35 ++--
 arch/powerpc/kernel/exceptions-64s.S         |  41 ++++-
 arch/powerpc/kernel/interrupt_64.S           |  92 +++++-----
 arch/powerpc/kernel/signal_32.c              |   2 +-
 arch/powerpc/kernel/sys_ppc32.c              |  66 +++-----
 arch/powerpc/kernel/syscall.c                |  32 ++--
 arch/powerpc/kernel/syscalls.c               |  61 ++++---
 arch/powerpc/kernel/syscalls/syscall.tbl     |  24 +--
 arch/powerpc/kernel/{systbl.S => systbl.c}   |  30 ++--
 arch/powerpc/kernel/vdso.c                   |   6 +-
 arch/powerpc/perf/callchain_32.c             |   2 +-
 arch/powerpc/platforms/cell/spu_callbacks.c  |   6 +-
 include/asm-generic/compat.h                 |   9 +-
 .../arch/powerpc/entry/syscalls/syscall.tbl  |  24 +--
 23 files changed, 491 insertions(+), 258 deletions(-)
 create mode 100644 arch/powerpc/include/asm/syscall_wrapper.h
 rename arch/powerpc/{kernel/ppc32.h => include/asm/syscalls_32.h} (100%)
 rename arch/powerpc/kernel/{systbl.S => systbl.c} (55%)
Signature · 1 line
2.34.1