Skip to content

drm/udl: Better modesetting, hot-unplug, protocol

Thomas Zimmermann dri-devel 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest16 patches 0 repliesNew
  2. v116 patches 19 repliesSuperseded

Changes in v2 from the cover letter

* use FIELD_GET macros when programming scanout address (Javier)
* improve commit messages (Javier)
* drop empty atomic_disable plane helper

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16drm/udl: Rename struct udl_drm_connector to struct udl_connectordrivers/gpu/drm/udl/udl_connector.c drivers/gpu/drm/udl/udl_connector.h+13 -160 replies
2/16drm/udl: Test pixel limit in mode-config's mode-valid functiondrivers/gpu/drm/udl/udl_connector.c drivers/gpu/drm/udl/udl_modeset.c+14 -140 replies
3/16drm/udl: Use USB timeout constant when reading EDIDdrivers/gpu/drm/udl/udl_connector.c+1 -10 replies
4/16drm/udl: Various improvements to the connectordrivers/gpu/drm/udl/udl_connector.c+40 -240 replies
5/16drm/udl: Move connector to modesetting codedrivers/gpu/drm/udl/Makefile drivers/gpu/drm/udl/udl_connector.c drivers/gpu/drm/udl/udl_connector.h +2 more+134 -1540 replies
6/16drm/udl: Remove udl_simple_display_pipe_mode_valid()drivers/gpu/drm/udl/udl_modeset.c+0 -80 replies
7/16drm/udl: Convert to atomic-modesetting helpersdrivers/gpu/drm/udl/udl_drv.h drivers/gpu/drm/udl/udl_modeset.c+112 -540 replies
8/16drm/udl: Simplify modesetting in CRTC's enable functiondrivers/gpu/drm/udl/udl_drv.h drivers/gpu/drm/udl/udl_modeset.c+14 -500 replies
9/16drm/udl: Support DRM hot-unpluggingdrivers/gpu/drm/udl/udl_modeset.c+37 -60 replies
10/16drm/udl: Use damage iteratordrivers/gpu/drm/udl/udl_modeset.c+21 -210 replies
11/16drm/udl: Move register constants to udl_proto.hdrivers/gpu/drm/udl/udl_drv.h drivers/gpu/drm/udl/udl_modeset.c drivers/gpu/drm/udl/udl_proto.h+21 -150 replies
12/16drm/udl: Add constants for display-mode registersdrivers/gpu/drm/udl/udl_modeset.c drivers/gpu/drm/udl/udl_proto.h+47 -700 replies
13/16drm/udl: Add register constants for color depthdrivers/gpu/drm/udl/udl_modeset.c drivers/gpu/drm/udl/udl_proto.h+4 -10 replies
14/16drm/udl: Add register constants for video locksdrivers/gpu/drm/udl/udl_modeset.c drivers/gpu/drm/udl/udl_proto.h+7 -20 replies
15/16drm/udl: Add register constants for framebuffer scanout addressesdrivers/gpu/drm/udl/udl_modeset.c drivers/gpu/drm/udl/udl_proto.h+38 -90 replies
16/16drm/udl: Add constants for commandsdrivers/gpu/drm/udl/udl_drv.h drivers/gpu/drm/udl/udl_modeset.c drivers/gpu/drm/udl/udl_proto.h +1 more+28 -200 replies

Reviews trailers per patch

All 16 patches have a Reviewed-by or Acked-by.

PatchJavier Martinez Canillas
1/16R-b
2/16R-b
3/16R-b
4/16R-b
5/16R-b
6/16R-b
7/16R-b
8/16R-b
9/16R-b
10/16R-b
11/16R-b
12/16R-b
13/16R-b
14/16R-b
15/16R-b
16/16R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/16] drm/udl: Better modesetting, hot-unplug, protocol

This patchset reworks the udl driver's modesetting code.

Patches #1 to #5 improve the connector code with various updates.

Patches #6 to #10 improve the modesetting code. Patch #7 replaces the simple-KMS helpers with the regular atomic helpers. Patch #9 adds DRM hot-unplugging. The driver had some unplugging support via USB functions, the DRM side was probably not prepared yet. Patch #10 changes damage updates to the damage iterator. This minimizes the amount of data to send over USB.

Patches #11 to #16 add protocol constants for the various UDL display operations.

Tested with X11, console and Weston.

v2:
* use FIELD_GET macros when programming scanout address (Javier)
* improve commit messages (Javier)
* drop empty atomic_disable plane helper

Thomas Zimmermann (16):
drm/udl: Rename struct udl_drm_connector to struct udl_connector drm/udl: Test pixel limit in mode-config's mode-valid function drm/udl: Use USB timeout constant when reading EDID drm/udl: Various improvements to the connector drm/udl: Move connector to modesetting code
drm/udl: Remove udl_simple_display_pipe_mode_valid() drm/udl: Convert to atomic-modesetting helpers drm/udl: Simplify modesetting in CRTC's enable function drm/udl: Support DRM hot-unplugging
drm/udl: Use damage iterator
drm/udl: Move register constants to udl_proto.h drm/udl: Add constants for display-mode registers drm/udl: Add register constants for color depth drm/udl: Add register constants for video locks drm/udl: Add register constants for framebuffer scanout addresses drm/udl: Add constants for commands

 drivers/gpu/drm/udl/Makefile        |   2 +-
 drivers/gpu/drm/udl/udl_connector.c | 139 -------
 drivers/gpu/drm/udl/udl_connector.h |  15 -
 drivers/gpu/drm/udl/udl_drv.h       |  42 +--
 drivers/gpu/drm/udl/udl_modeset.c   | 563 ++++++++++++++++++----------
 drivers/gpu/drm/udl/udl_proto.h     |  68 ++++
 drivers/gpu/drm/udl/udl_transfer.c  |   7 +-
 7 files changed, 451 insertions(+), 385 deletions(-)
 delete mode 100644 drivers/gpu/drm/udl/udl_connector.c
 delete mode 100644 drivers/gpu/drm/udl/udl_connector.h
 create mode 100644 drivers/gpu/drm/udl/udl_proto.h
Signature · 1 line
2.37.3