Skip to content

dmaengine: idxd: Fix up re-enabling device workqueues

Jerry Snitselaar dmaengine lkml 2 versions – Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 3 repliesApplied
  2. v12 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Clear bit in case where idxd_wq_enable() fails during re-init.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2dmaengine: idxd: Set wq state to disabled in idxd_wq_disable_cleanup()drivers/dma/idxd/device.c+1 -11 reply
2/2dmaengine: idxd: track enabled workqueues in bitmapdrivers/dma/idxd/device.c drivers/dma/idxd/idxd.h drivers/dma/idxd/init.c +2 more+14 -21 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDave Jiang
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] dmaengine: idxd: Fix up re-enabling device workqueues

Currently if a software reset is attempted on an idxd device the workqueues will not be re-enabled, because it will see incorrectly see that wq->state is already set to IDXD_WQ_ENABLED. So set the workqueue state to disabled in idxd_wq_disable_cleanup(), and use a bitmap to track which workqueues have been enabled so they can be re-enabled during device re-initialization.

Changes from v1 to v2:
- Clear bit in case where idxd_wq_enable() fails during re-init.

Cc Fenghua Yu <[email protected]>
Cc Dave Jiang <[email protected]>
Cc Vinod Koul <[email protected]>

Jerry Snitselaar (2):
dmaengine: idxd: Set wq state to disabled in idxd_wq_disable_cleanup()
dmaengine: idxd: track enabled workqueues in bitmap

 drivers/dma/idxd/device.c | 4 +++-
 drivers/dma/idxd/idxd.h   | 2 ++
 drivers/dma/idxd/init.c   | 6 ++++++
 drivers/dma/idxd/irq.c    | 5 +++--
 drivers/dma/idxd/sysfs.c  | 1 +
 5 files changed, 15 insertions(+), 3 deletions(-)
Signature · 1 line
2.37.2