Skip to content

veristat: CSV output, comparison mode, filtering

Andrii Nakryiko bpf 2 versions – Applied

Status from this message: This series was applied to bpf/bpf-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 2 repliesApplied 4/4
  2. v13 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- split out double-free fix into patch #1 (Yonghong);
- fixed typo in verbose flag (Quentin);
- baseline and comparison stats were reversed in output table, fixed that.

Patches in v2 All 4 applied

#Subject and filesSizeRepliesApplied
1/4selftests/bpf: fix double bpf_object__close() in veristatetools/testing/selftests/bpf/veristat.c+0 -10 repliesApplied
2/4selftests/bpf: add CSV output mode for veristattools/testing/selftests/bpf/veristat.c+75 -360 repliesApplied
3/4selftests/bpf: add comparison mode to veristattools/testing/selftests/bpf/veristat.c+492 -510 repliesApplied
4/4selftests/bpf: add ability to filter programs in veristattools/testing/selftests/bpf/veristat.c tools/testing/selftests/bpf/veristat.cfg+227 -20 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 bpf-next 0/4] veristat: CSV output, comparison mode, filtering

Add three more critical features to veristat tool, which make it sufficient for a practical work on BPF verifier:

- CSV output, which allows easier programmatic post-processing of stats;

- building upon CSV output, veristat now supports comparison mode, in which two previously captured CSV outputs from veristat are compared with each other in a convenient form;

- flexible allow/deny filtering using globs for BPF object files and programs, allowing to narrow down target BPF programs to be verified.

See individual patches for more details and examples.

v1->v2:
- split out double-free fix into patch #1 (Yonghong);
- fixed typo in verbose flag (Quentin);
- baseline and comparison stats were reversed in output table, fixed that.

Andrii Nakryiko (4):
selftests/bpf: fix double bpf_object__close() in veristate selftests/bpf: add CSV output mode for veristat selftests/bpf: add comparison mode to veristat selftests/bpf: add ability to filter programs in veristat

 tools/testing/selftests/bpf/veristat.c   | 853 ++++++++++++++++++++---
 tools/testing/selftests/bpf/veristat.cfg |  17 +
 2 files changed, 787 insertions(+), 83 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/veristat.cfg
Signature · 1 line
2.30.2