Skip to content

rtnetlink: Honour NLM_F_ECHO flag in rtnl_{new, del}link

Hangbin Liu netdev 7 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest4 patches 1 replyApplied 4/4
  2. v64 patches 0 repliesSuperseded
  3. v54 patches 12 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v44 patches0 repliesSuperseded
v31 patch9 repliesSuperseded
v21 patch3 repliesSuperseded
v11 patch15 repliesSuperseded

Changes in v7 from the cover letter

1) Fix unregister_netdevice_many() prototype warnning in patch 02

Patches in v7 All 4 applied

#Subject and filesSizeRepliesApplied
1/4rtnetlink: pass netlink message header and portid to rtnl_configure_link()drivers/net/can/vxcan.c drivers/net/geneve.c drivers/net/veth.c +10 more+61 -420 repliesApplied
2/4net: add new helper unregister_netdevice_many_notifynet/core/dev.c net/core/dev.h+20 -100 repliesApplied
3/4rtnetlink: Honour NLM_F_ECHO flag in rtnl_newlink_createnet/core/rtnetlink.c+4 -20 repliesApplied
4/4rtnetlink: Honour NLM_F_ECHO flag in rtnl_delete_linkinclude/net/rtnetlink.h net/core/rtnetlink.c net/openvswitch/vport-geneve.c +3 more+9 -80 repliesApplied

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchGuillaume Nault
SeriesR-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCHv7 net-next 0/4] rtnetlink: Honour NLM_F_ECHO flag in rtnl_{new, del}link

Netlink messages are used for communicating between user and kernel space. When user space configures the kernel with netlink messages, it can set the NLM_F_ECHO flag to request the kernel to send the applied configuration back to the caller. This allows user space to retrieve configuration information that are filled by the kernel (either because these parameters can only be set by the kernel or because user space let the kernel choose a default value).

The kernel has support this feature in some places like RTM_{NEW, DEL}ADDR, RTM_{NEW, DEL}ROUTE. This patch set handles NLM_F_ECHO flag and send link info back after rtnl_{new, del}link.

v7:
1) Fix unregister_netdevice_many() prototype warnning in patch 02

v6:
1) Rename pid to portid, make all nlh const
2) Re-order the portid, nlh parameter for each function
3) Do not add rtnl_configure_link_notify() warpper as Guillaume suggested. Just modify rtnl_configure_link() directly in patch 01. Also remove the rtmsg_ifinfo_nlh() wrapper.
4) Un-export unregister_netdevice_many_notify() in patch 02

v5:
1) Make rtnl_configure_link_notify static, reported by kernel test robot

v4:
1) Add rtnl_configure_link_notify() helper so rtnl_newlink_create could use it instead of creating new notify function.
2) Add unregister_netdevice_many_notify() helper so rtnl_delete_link() could use it instead of creating new notify function
3) Split the previous patch to 4 small patches for easier reviewing.

v3:
1) Fix group parameter in rtnl_notify.
2) Use helper rtmsg_ifinfo_build_skb() instead re-write a new one.

v2:
1) Rename rtnl_echo_link_info() to rtnl_link_notify().
2) Remove IFLA_LINK_NETNSID and IFLA_EXT_MASK, which do not fit here.
3) Add NLM_F_ECHO in rtnl_dellink. But we can't re-use the rtnl_link_notify() helper as we need to get the link info before rtnl_delete_link().

Hangbin Liu (4):
rtnetlink: pass netlink message header and portid to
rtnl_configure_link()
net: add new helper unregister_netdevice_many_notify
rtnetlink: Honour NLM_F_ECHO flag in rtnl_newlink_create
rtnetlink: Honour NLM_F_ECHO flag in rtnl_delete_link

 drivers/net/can/vxcan.c        |  2 +-
 drivers/net/geneve.c           |  2 +-
 drivers/net/veth.c             |  2 +-
 drivers/net/vxlan/vxlan_core.c |  4 +--
 drivers/net/wwan/wwan_core.c   |  2 +-
 include/linux/netdevice.h      |  2 --
 include/linux/rtnetlink.h      |  9 ++++---
 include/net/netlink.h          | 11 ++++++++
 include/net/rtnetlink.h        |  5 ++--
 net/core/dev.c                 | 48 ++++++++++++++++++++--------------
 net/core/dev.h                 |  7 +++++
 net/core/rtnetlink.c           | 46 ++++++++++++++++++--------------
 net/ipv4/ip_gre.c              |  2 +-
 net/openvswitch/vport-geneve.c |  2 +-
 net/openvswitch/vport-gre.c    |  2 +-
 net/openvswitch/vport-netdev.c |  2 +-
 net/openvswitch/vport-vxlan.c  |  2 +-
 17 files changed, 91 insertions(+), 59 deletions(-)
Signature · 1 line
2.37.3