qga: Add FreeBSD support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest7 patches 2 repliesIn review
- v47 patches 3 repliesSuperseded
- v37 patches 10 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 7 patches | 12 replies | Superseded | |
| v1 | 5 patches | 8 replies | Superseded |
Changes in v5 from the cover letter
2: Left ga_wait_child() static in commands-posix.c.
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | qga: Add initial FreeBSD supportmeson.build qga/ qga/ +1 more | +33 | 0 replies | |
| 2/7 | qga: Move Linux-specific FS freeze/thaw code to a separate fileqga/ qga/ qga/ +1 more | +338 | 0 replies | |
| 3/7 | qga: Add UFS freeze/thaw support for FreeBSDqga/ qga/ qga/ +2 more | +334 | 0 replies | |
| 4/7 | qga: Add shutdown/halt/reboot support for FreeBSDqga/ | +7 | 0 replies | |
| 5/7 | qga: Add support for user password setting in FreeBSDqga/ | +25 | 0 replies | |
| 6/7 | qga: Move HW address getting to a separate functionqga/ qga/ qga/ | +78 | 0 replies | |
| 7/7 | qga: Add HW address getting for FreeBSDqga/ | +15 | 0 replies |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Konstantin Kostiuk | Marc-André Lureau |
|---|---|---|
| 1/7 | R-b | A-b |
| 2/7 | R-b | R-b |
| 3/7 | R-b | R-b |
| 4/7 | R-b | R-b |
| 5/7 | R-b | R-b |
| 6/7 | R-b | R-b |
| 7/7 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 0/7] qga: Add FreeBSD support
Add freeze/thaw, shutdown/halt/reboot, password setting and guest-network-get-interfaces command support for FreeBSD.
v5:
2: Left ga_wait_child() static in commands-posix.c.
v4:
6,7: Return bool instead int in guest_get_hw_addr().
v3:
1: Add a comment about echo suppressing.
5: Replace code moving by splitting the code into a few blocks under
architecture conditions.
5,6: Move actions with dumb qmp_guest_set_user_password() to
the appropriate patch.
6: Fix error/obtained return.
v2:
1: Reject the idea to move all the Linux-specific code to a separate file.
First commit now adds initial support of FreeBSD. Fixed device paths and fixed virtio device initialization (disable echo). Add comment why we should disable the code under HAVE_GETIFADDRS in FreeBSD.
2: Replace the second commit (which now is the first) by moving
Linux-specific freeze/thaw code to a separate file commands-linux.c.
3: Add error raising if stat() returns error. Replaced strcmp() calls by
g_str_equal(). Add a comment explaining why UFSRESUME isn't necessary.
4: Replace #elifdef by #elif defined().
5: Now the code doesn't move from one file to aanother but still is
moving inside file so the patch doesn't become easier to review. =( Fixed typos.
6,7: New patches. Add guest-network-get-interfaces command support.
Alexander Ivanov (7):
qga: Add initial FreeBSD support
qga: Move Linux-specific FS freeze/thaw code to a separate file
qga: Add UFS freeze/thaw support for FreeBSD
qga: Add shutdown/halt/reboot support for FreeBSD
qga: Add support for user password setting in FreeBSD
qga: Move HW address getting to a separate function
qga: Add HW address getting for FreeBSD
meson.build | 2 +- qga/channel-posix.c | 19 ++ qga/commands-bsd.c | 200 +++++++++++++ qga/commands-common.h | 51 ++++ qga/commands-linux.c | 286 +++++++++++++++++++ qga/commands-posix.c | 639 ++++++++++++++---------------------------- qga/main.c | 13 +- qga/meson.build | 6 + 8 files changed, 778 insertions(+), 438 deletions(-) create mode 100644 qga/commands-bsd.c create mode 100644 qga/commands-linux.c
Signature · 1 line
2.34.1