Enable alloc caching and batched freeing for passthrough
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest5 patches 10 repliesIn review
- v15 patches 20 repliesSuperseded
Changes in v2 from the cover letter
- Remove spurious semicolon
- Cleanup struct nvme_uring_cmd_pdu handling
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | block: enable batched allocation for blk_mq_alloc_request()block/ | +71 | 1 reply | |
| 2/5 | block: change request end_io handler to pass back a return valueblock/ block/ drivers/ +10 more | +65 | 0 replies | |
| 3/5 | block: allow end_io based requests in the completion batch handlingblock/ include/ | +13 | 1 reply | |
| 4/5 | nvme: split out metadata vs non metadata end_io uring_cmd completionsdrivers/ | +61 | 3 replies | |
| 5/5 | nvme: enable batched completions of passthrough IOdrivers/ | +1 | 2 replies |
Reviews trailers per patch
3 of 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Christoph Hellwig | Anuj Gupta | Sagi Grimberg | Keith Busch |
|---|---|---|---|---|
| Series | R-b | |||
| 1/5 | T-b | |||
| 2/5 | ||||
| 3/5 | R-b | |||
| 4/5 | R-b | R-b | R-b | |
| 5/5 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCHSET v2 0/5] Enable alloc caching and batched freeing for passthrough
Hi,
The passthrough IO path currently doesn't do any request allocation batching like we do for normal IO. Wire this up through the usual blk_mq_alloc_request() allocation helper.
Similarly, we don't currently supported batched completions for passthrough IO. Allow the request->end_io() handler to return back whether or not it retains ownership of the request. By default all handlers are converted to returning RQ_END_IO_NONE, which retains the existing behavior. But with that in place, we can tweak the nvme uring_cmd end_io handler to pass back ownership, and hence enable completion batching for passthrough requests as well.
This is good for a 10% improvement for passthrough performance. For a non-drive limited test case, passthrough IO is now more efficient than the regular bdev O_DIRECT path.
Changes since v1:
- Remove spurious semicolon
- Cleanup struct nvme_uring_cmd_pdu handling
Signature · 1 line
Jens Axboe