Skip to content

ftdi_sio driver improvements

Pali Rohár linux-usb 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest7 patches 13 repliesIn review

Changes in v3 from the cover letter

- Use u32 for div_value
- Add line break after the colons in switch
- Avoid ternary operators where possilble
- Use baud rate 9600 instead of 0 when unspecified
- Fix commit messages

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7USB: serial: ftdi_sio: Fix divisor overflowdrivers/usb/serial/ftdi_sio.c+6 -01 reply
2/7USB: serial: ftdi_sio: Add missing baud rate validationdrivers/usb/serial/ftdi_sio.c+3 -31 reply
3/7USB: serial: ftdi_sio: Extract SIO divisor code to functiondrivers/usb/serial/ftdi_sio.c+31 -147 replies
4/7USB: serial: ftdi_sio: Do not reset baud rate to 9600 Baud on errordrivers/usb/serial/ftdi_sio.c+35 -121 reply
5/7USB: serial: ftdi_sio: Fix baud rate rounding for ASYNC_SPD_CUSTdrivers/usb/serial/ftdi_sio.c+1 -11 reply
6/7USB: serial: ftdi_sio: Fix custom_divisor for TIOCGSERIAL and c_*speed for TCGETS2drivers/usb/serial/ftdi_sio.c+16 -01 reply
7/7USB: serial: ftdi_sio: Fill c_*speed fields with real baud ratedrivers/usb/serial/ftdi_sio.c+93 -01 reply

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by.

PatchMarek Behún
1/7T-b
2/7T-b
3/7T-b
4/7T-b
5/7T-b
6/7T-b
7/7T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/7] ftdi_sio driver improvements

Changes since v2:
- Use u32 for div_value
- Add line break after the colons in switch
- Avoid ternary operators where possilble
- Use baud rate 9600 instead of 0 when unspecified
- Fix commit messages

Pali Rohár (7):
USB: serial: ftdi_sio: Fix divisor overflow
USB: serial: ftdi_sio: Add missing baud rate validation
USB: serial: ftdi_sio: Extract SIO divisor code to function
USB: serial: ftdi_sio: Do not reset baud rate to 9600 Baud on error
USB: serial: ftdi_sio: Fix baud rate rounding for ASYNC_SPD_CUST
USB: serial: ftdi_sio: Fix custom_divisor for TIOCGSERIAL and c_*speed
for TCGETS2
USB: serial: ftdi_sio: Fill c_*speed fields with real baud rate

 drivers/usb/serial/ftdi_sio.c | 215 +++++++++++++++++++++++++++++-----
 1 file changed, 185 insertions(+), 30 deletions(-)
Signature · 1 line
2.20.1