Skip to content

lockinig/rwsem: Fix rwsem bugs & enable true lock handoff

Waiman Long lkml oe-lkp stable 7 versions – Applied

Status from this message: The following commit has been merged into the locking/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest4 patches 7 repliesApplied
  2. v66 patches 14 repliesSuperseded
  3. v56 patches 1 replySuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v45 patches2 repliesSuperseded
v35 patches16 repliesSuperseded
v22 patches7 repliesSuperseded
v11 patch19 repliesSuperseded

Changes in v7 from the cover letter

- Add a comment to down_read_non_owner() in patch 2.
- Drop v6 patches 4 & 6 and simplify the direct rwsem lock handoff patch as suggested by PeterZ.

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/4locking/rwsem: Prevent non-first waiter from spinning in down_write() slowpathkernel/locking/rwsem.c+9 -100 replies
2/4locking/rwsem: Disable preemption at all down_read*() and up_read() code pathskernel/locking/rwsem.c+24 -60 replies
3/4locking/rwsem: Disable preemption at all down_write*() and up_write() code pathskernel/locking/rwsem.c+19 -190 replies
4/4locking/rwsem: Enable direct rwsem lock handoffkernel/locking/rwsem.c+63 -114 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by.

PatchMukesh Ojha
1/4Reviewed-and-tested-by
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/4] lockinig/rwsem: Fix rwsem bugs & enable true lock handoff

v7:
- Add a comment to down_read_non_owner() in patch 2.
- Drop v6 patches 4 & 6 and simplify the direct rwsem lock handoff patch as suggested by PeterZ.

v6:
- Fix an error in patch 2 reported by kernel test robot.

v5:
- Drop patch 2 and replace it with 2 new patches disabling preemption on all reader functions and writer functions respectively. The other patches are adjusted accordingly.

It turns out the current waiter optimistic spinning code does not work that well if we have RT tasks in the mix. This patch series include two different fixes to resolve those issues. The last 3 patches modify the handoff code to implement true lock handoff similar to that of mutex.

Waiman Long (4):
locking/rwsem: Prevent non-first waiter from spinning in down_write()
slowpath
locking/rwsem: Disable preemption at all down_read*() and up_read()
code paths
locking/rwsem: Disable preemption at all down_write*() and up_write()
code paths
locking/rwsem: Enable direct rwsem lock handoff

 kernel/locking/rwsem.c | 161 +++++++++++++++++++++++++++++------------
 1 file changed, 115 insertions(+), 46 deletions(-)
Signature · 1 line
2.31.1