KVM: selftests: Fix and clean up emulator_error_test
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest10 patches 0 repliesNew
- v310 patches 9 repliesSuperseded
- v28 patches 10 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 4 patches | 3 replies | Superseded |
Changes in v4 from the cover letter
- Collect more R-b tags from Sean.
- Assert no #PF when TDP is enabled [Sean]
- Avoid 'we' pronoun in commit message [Sean]
- Bundle assert+skip in one function [Sean]
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | KVM: selftests: Rename emulator_error_test to smaller_maxphyaddr_emulation_testtools/ tools/ tools/ | +4 | 0 replies | |
| 2/10 | KVM: selftests: Explicitly require instructions bytestools/ | +20 | 0 replies | |
| 3/10 | KVM: selftests: Delete dead ucall codetools/ | +1 | 0 replies | |
| 4/10 | KVM: selftests: Move flds instruction emulation failure handling to headertools/ tools/ | +59 | 0 replies | |
| 5/10 | KVM: x86/mmu: Use BIT{,_ULL}() for PFERR masksarch/ | +10 | 0 replies | |
| 6/10 | KVM: selftests: Copy KVM PFERR masks into selfteststools/ | +23 | 0 replies | |
| 7/10 | KVM: selftests: Avoid JMP in non-faulting path of KVM_ASM_SAFE()tools/ | +3 | 0 replies | |
| 8/10 | KVM: selftests: Provide error code as a KVM_ASM_SAFE() outputtools/ tools/ tools/ | +30 | 0 replies | |
| 9/10 | KVM: selftests: Expect #PF(RSVD) when TDP is disabledtools/ | +46 | 0 replies | |
| 10/10 | KVM: selftests: Add a test for KVM_CAP_EXIT_ON_EMULATION_FAILUREtools/ tools/ tools/ | +47 | 0 replies |
Reviews trailers per patch
5 of 10 patches have a Reviewed-by or Acked-by.
| Patch | Sean Christopherson |
|---|---|
| 1/10 | R-b |
| 2/10 | R-b |
| 3/10 | R-b |
| 4/10 | |
| 5/10 | R-b |
| 6/10 | R-b |
| 7/10 | |
| 8/10 | |
| 9/10 | |
| 10/10 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 00/10] KVM: selftests: Fix and clean up emulator_error_test
Miscellaneous fixes and cleanups to emulator_error_test. The reason I started looking at this test is because it fails when TDP is disabled, which pollutes my test results wheneveer I am testing a new series for upstream.
v4:
- Collect more R-b tags from Sean.
- Assert no #PF when TDP is enabled [Sean]
- Avoid 'we' pronoun in commit message [Sean]
- Bundle assert+skip in one function [Sean]
v3: https://lore.kernel.org/kvm/[email protected]/
- Collect R-b tags from Sean.
- Drop ModR/M decoding in favor of hard-coded instruction [Sean]
- Fix gspurious gcc warning about using uninitialized variable [Sean]
- Drop assert_ucall_done() helper [Sean]
- Spelling fixes [Sean]
- Use kvm_asm_safe*() to check #PF(RSVD) instead of an exception handler [Sean]
v2: https://lore.kernel.org/kvm/[email protected]/
- Split emulator_error_test into 2 separate tests to ensure continued test coverage of KVM emulation in response to EPT violations when "allow_smaller_maxphyaddr && guest.MAXPHYADDR < host.MAXPHADDR". [Sean]
- Test that flds generates #PF(RSVD) when TDP is disabled [Sean]
v1: https://lore.kernel.org/kvm/[email protected]/
David Matlack (8):
KVM: selftests: Rename emulator_error_test to
smaller_maxphyaddr_emulation_test
KVM: selftests: Explicitly require instructions bytes
KVM: selftests: Delete dead ucall code
KVM: selftests: Move flds instruction emulation failure handling to
header
KVM: x86/mmu: Use BIT{,_ULL}() for PFERR masks
KVM: selftests: Copy KVM PFERR masks into selftests
KVM: selftests: Expect #PF(RSVD) when TDP is disabled
KVM: selftests: Add a test for KVM_CAP_EXIT_ON_EMULATION_FAILURE
Sean Christopherson (2):
KVM: selftests: Avoid JMP in non-faulting path of KVM_ASM_SAFE()
KVM: selftests: Provide error code as a KVM_ASM_SAFE() output
arch/x86/include/asm/kvm_host.h | 20 +- tools/testing/selftests/kvm/.gitignore | 3 +- tools/testing/selftests/kvm/Makefile | 3 +- .../selftests/kvm/include/x86_64/processor.h | 66 ++++-- .../selftests/kvm/lib/x86_64/processor.c | 1 + .../kvm/x86_64/emulator_error_test.c | 193 ------------------ .../x86_64/exit_on_emulation_failure_test.c | 45 ++++ .../selftests/kvm/x86_64/flds_emulation.h | 55 +++++ .../selftests/kvm/x86_64/hyperv_features.c | 3 +- .../smaller_maxphyaddr_emulation_test.c | 112 ++++++++++ 10 files changed, 280 insertions(+), 221 deletions(-) delete mode 100644 tools/testing/selftests/kvm/x86_64/emulator_error_test.c create mode 100644 tools/testing/selftests/kvm/x86_64/exit_on_emulation_failure_test.c create mode 100644 tools/testing/selftests/kvm/x86_64/flds_emulation.h create mode 100644 tools/testing/selftests/kvm/x86_64/smaller_maxphyaddr_emulation_test.c
base-commit: d5af637323dd156bad071a3f8fc0d7166cca1276
Signature · 1 line
2.38.1.273.g43a17bfeac-goog