Skip to content

drm/i915: Fix watermark calculations with various CCS modifiers

Ville Syrjala intel-gfx stable 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 0 repliesNew
  2. v15 patches 4 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drm/i915: Fix watermark calculations for gen12+ RC CCS modifierdrivers/gpu/drm/i915/display/skl_watermark.c+4 -20 replies
2/6drm/i915: Fix watermark calculations for gen12+ MC CCS modifierdrivers/gpu/drm/i915/display/skl_watermark.c+4 -20 replies
3/6drm/i915: Fix watermark calculations for gen12+ CCS+CC modifierdrivers/gpu/drm/i915/display/skl_watermark.c+4 -20 replies
4/6drm/i915: Fix watermark calculations for DG2 CCS modifiersdrivers/gpu/drm/i915/display/skl_watermark.c+6 -20 replies
5/6drm/i915: Fix watermark calculations for DG2 CCS+CC modifierdrivers/gpu/drm/i915/display/skl_watermark.c+4 -20 replies
6/6drm/i915: Simplify modifier lookup in watermark codedrivers/gpu/drm/i915/display/intel_fb.c drivers/gpu/drm/i915/display/intel_fb.h drivers/gpu/drm/i915/display/skl_watermark.c+17 -190 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchJuha-Pekka Heikkila
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Intel-gfx] [PATCH v2 0/6] drm/i915: Fix watermark calculations with various CCS modifiers

From: Ville Syrjälä <[email protected]>

We are neglegting to consider all the new CCS modifiers as Y-tiled in the watermark calculations. So we are incorrectrly calculation the watermarks as if dealing with a linear surface.

v2: Fix tgl RC CCS vs. MC CCS to separate patches since they
need separate fixes tags

Ville Syrjälä (6):
drm/i915: Fix watermark calculations for gen12+ RC CCS modifier drm/i915: Fix watermark calculations for gen12+ MC CCS modifier drm/i915: Fix watermark calculations for gen12+ CCS+CC modifier drm/i915: Fix watermark calculations for DG2 CCS modifiers drm/i915: Fix watermark calculations for DG2 CCS+CC modifier drm/i915: Simplify modifier lookup in watermark code

 drivers/gpu/drm/i915/display/intel_fb.c      | 13 +++++++++++++
 drivers/gpu/drm/i915/display/intel_fb.h      |  1 +
 drivers/gpu/drm/i915/display/skl_watermark.c | 10 +++-------
 3 files changed, 17 insertions(+), 7 deletions(-)
Signature · 1 line
2.35.1