Skip to content

mm/ksm: break_ksm() cleanups and fixes

David Hildenbrand linux-mm lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 2 repliesIn review 8 of 9 applied
  2. v17 patches 16 repliesSuperseded

Changes in v2 from the cover letter

* "selftests/vm: add KSM unmerge tests"
-> Add new unmerge tests
* "mm/ksm: fix KSM COW breaking with userfaultfd-wp via FAULT_FLAG_UNSHARE" -> Simplify patch description now that we have a selftest
* "mm/pagewalk: don't trigger test_walk() in walk_page_vma()" -> Added
* "mm/pagewalk: add walk_page_range_vma()"
-> Don't call test_walk()
* "mm/ksm: convert break_ksm() to use walk_page_range_vma()"
-> Simplify and fix missing unlock, fix missing "static"

Patches in v2 8 of 9 applied

#Subject and filesSizeRepliesApplied
1/9selftests/vm: add test to measure MADV_UNMERGEABLE performancetools/testing/selftests/vm/ksm_tests.c+74 -20 repliesApplied
2/9mm/ksm: simplify break_ksm() to not rely on VM_FAULT_WRITEmm/ksm.c+13 -120 repliesApplied
3/9mm: remove VM_FAULT_WRITEinclude/linux/mm_types.h mm/huge_memory.c mm/memory.c+5 -90 repliesApplied
4/9selftests/vm: add KSM unmerge teststools/testing/selftests/vm/Makefile tools/testing/selftests/vm/ksm_functional_tests.c tools/testing/selftests/vm/run_vmtests.sh +2 more+294 -00 repliesApplied
5/9mm/ksm: fix KSM COW breaking with userfaultfd-wp via FAULT_FLAG_UNSHAREmm/ksm.c+5 -70 repliesApplied
6/9mm/pagewalk: don't trigger test_walk() in walk_page_vma()include/linux/pagewalk.h mm/pagewalk.c+2 -70 repliesApplied
7/9mm/pagewalk: add walk_page_range_vma()include/linux/pagewalk.h mm/pagewalk.c+23 -00 repliesApplied
8/9mm/ksm: convert break_ksm() to use walk_page_range_vma()mm/ksm.c+39 -100 repliesApplied
9/9mm/gup: remove FOLL_MIGRATIONinclude/linux/mm.h mm/gup.c+5 -510 replies

Reviews trailers per patch

4 of 9 patches have a Reviewed-by or Acked-by.

PatchPeter Xu
1/9A-b
2/9A-b
3/9A-b
4/9
5/9A-b
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/9] mm/ksm: break_ksm() cleanups and fixes

This series cleans up and fixes break_ksm(). In summary, we no longer use fake write faults to break COW but instead FAULT_FLAG_UNSHARE. Further, we move away from using follow_page() --- that we can hopefully remove completely at one point --- and use new walk_page_range_vma() instead.

Fortunately, we can get rid of VM_FAULT_WRITE and FOLL_MIGRATION in common code now.

Extend the existing ksm tests by an unmerge benchmark, and a some new unmerge tests.

Add a selftest to measure MADV_UNMERGEABLE performance. In my setup (AMD Ryzen 9 3900X), running the KSM selftest to test unmerge performance on 2 GiB (taskset 0x8 ./ksm_tests -D -s 2048), this results in a performance degradation of ~6% -- 7% (old: ~5250 MiB/s, new: ~4900 MiB/s). I don't think we particularly care for now, but it's good to be aware of the implication.

Cc Andrew Morton <[email protected]>
Cc Shuah Khan <[email protected]>
Cc Hugh Dickins <[email protected]>
Cc Vlastimil Babka <[email protected]>
Cc Peter Xu <[email protected]>
Cc Andrea Arcangeli <[email protected]>
Cc "Matthew Wilcox (Oracle)" <[email protected]>
Cc Jason Gunthorpe <[email protected]>
Cc John Hubbard <[email protected]>

v1 -> v2:
* "selftests/vm: add KSM unmerge tests"
-> Add new unmerge tests
* "mm/ksm: fix KSM COW breaking with userfaultfd-wp via FAULT_FLAG_UNSHARE" -> Simplify patch description now that we have a selftest
* "mm/pagewalk: don't trigger test_walk() in walk_page_vma()" -> Added
* "mm/pagewalk: add walk_page_range_vma()"
-> Don't call test_walk()
* "mm/ksm: convert break_ksm() to use walk_page_range_vma()"
-> Simplify and fix missing unlock, fix missing "static"

David Hildenbrand (9):
selftests/vm: add test to measure MADV_UNMERGEABLE performance mm/ksm: simplify break_ksm() to not rely on VM_FAULT_WRITE
mm: remove VM_FAULT_WRITE
selftests/vm: add KSM unmerge tests
mm/ksm: fix KSM COW breaking with userfaultfd-wp via
FAULT_FLAG_UNSHARE
mm/pagewalk: don't trigger test_walk() in walk_page_vma() mm/pagewalk: add walk_page_range_vma()
mm/ksm: convert break_ksm() to use walk_page_range_vma() mm/gup: remove FOLL_MIGRATION

 include/linux/mm.h                            |   1 -
 include/linux/mm_types.h                      |   3 -
 include/linux/pagewalk.h                      |   5 +
 mm/gup.c                                      |  55 +---
 mm/huge_memory.c                              |   2 +-
 mm/ksm.c                                      |  78 +++--
 mm/memory.c                                   |   9 +-
 mm/pagewalk.c                                 |  27 +-
 tools/testing/selftests/vm/Makefile           |   2 +
 .../selftests/vm/ksm_functional_tests.c       | 279 ++++++++++++++++++
 tools/testing/selftests/vm/ksm_tests.c        |  76 ++++-
 tools/testing/selftests/vm/run_vmtests.sh     |   2 +
 tools/testing/selftests/vm/vm_util.c          |  10 +
 tools/testing/selftests/vm/vm_util.h          |   1 +
 14 files changed, 456 insertions(+), 94 deletions(-)
 create mode 100644 tools/testing/selftests/vm/ksm_functional_tests.c

base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780

Signature · 1 line
2.37.3