Skip to content

perf stat: Small random cleanups (v2)

Namhyung Kim linux-perf-users lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7perf stat: Convert perf_stat_evsel.res_stats arraytools/perf/util/stat-display.c tools/perf/util/stat.c tools/perf/util/stat.h+5 -90 replies
2/7perf stat: Don't call perf_stat_evsel_id_init() repeatedlytools/perf/util/stat.c+1 -10 replies
3/7perf stat: Rename saved_value->cpu_map_idxtools/perf/util/stat-shadow.c tools/perf/util/stat.h+157 -1570 replies
4/7perf stat: Use thread map index for shadow stattools/perf/util/stat-display.c tools/perf/util/stat-shadow.c tools/perf/util/stat.c+12 -180 replies
5/7perf stat: Kill unused per-thread runtime statstools/perf/builtin-stat.c tools/perf/util/stat.h+0 -560 replies
6/7perf stat: Don't compare runtime stat for shadow statstools/perf/util/stat-shadow.c+0 -120 replies
7/7perf stat: Rename to aggr_cpu_id.thread_idxtools/perf/tests/topology.c tools/perf/util/cpumap.c tools/perf/util/cpumap.h +1 more+16 -160 replies

Reviews trailers per patch

5 of 7 patches have a Reviewed-by or Acked-by.

PatchJames Clark
1/7R-b
2/7R-b
3/7
4/7R-b
5/7R-b
6/7R-b
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCHSET 0/7] perf stat: Small random cleanups (v2)

Hello,

I'm working on perf stat and I found some items to clean up. This time I removed runtime stats for per-thread aggregation mode which we can simply use thread map index to compare the shadow stat values in the rt_stat.

Changes from v1)
* renaming missing parts in headers (James)
* add a comment for map_idx (Ian)
* add Reviewed-by from James

The code is available at 'perf/stat-cleanup-v2' branch in

git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Thanks,
Namhyung

Namhyung Kim (7):
perf stat: Convert perf_stat_evsel.res_stats array perf stat: Don't call perf_stat_evsel_id_init() repeatedly perf stat: Rename saved_value->cpu_map_idx
perf stat: Use thread map index for shadow stat perf stat: Kill unused per-thread runtime stats perf stat: Don't compare runtime stat for shadow stats perf stat: Rename to aggr_cpu_id.thread_idx

 tools/perf/builtin-stat.c      |  54 ------
 tools/perf/tests/topology.c    |  10 +-
 tools/perf/util/cpumap.c       |   8 +-
 tools/perf/util/cpumap.h       |   2 +-
 tools/perf/util/stat-display.c |  32 ++--
 tools/perf/util/stat-shadow.c  | 320 ++++++++++++++++-----------------
 tools/perf/util/stat.c         |  20 +--
 tools/perf/util/stat.h         |  10 +-
 8 files changed, 189 insertions(+), 267 deletions(-)

base-commit: 62e64c9d2fd12839c02f1b3e8b873e7cb34e8720

Signature · 1 line
2.38.0.rc1.362.ged0d419d3c-goog