pwm: pxa: Fixes for enable/disable transitions
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest6 patches 3 repliesIn review
- v25 patches 9 repliesSuperseded
- v12 patches 2 repliesSuperseded
Changes in v3 from the cover letter
- Switch to abrupt shutdown mode instead of the delay hack from v2.
- Fix commit message explaining why duty cycle is set to 0.
- Add documentation link and limitations section at top of file.
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | pwm: pxa: Remove pxa_pwm_enable/disabledrivers/ | +3 | 0 replies | |
| 2/6 | pwm: pxa: Set duty cycle to 0 when disabling PWMdrivers/ | +16 | 1 reply | |
| 3/6 | pwm: pxa: Remove clk enable/disable from pxa_pwm_configdrivers/ | +0 | 0 replies | |
| 4/6 | pwm: pxa: Use abrupt shutdown modedrivers/ | +1 | 1 reply | |
| 5/6 | pwm: pxa: Add reference manual link and limitationsdrivers/ | +7 | 1 reply | |
| 6/6 | pwm: pxa: Enable for MMP platformdrivers/ | +1 | 0 replies |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Uwe Kleine-König |
|---|---|
| 1/6 | R-b |
| 2/6 | R-b |
| 3/6 | R-b |
| 4/6 | R-b |
| 5/6 | R-b |
| 6/6 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/6] pwm: pxa: Fixes for enable/disable transitions
I ran into a couple of problems while getting this driver working on the PXA168. It wouldn't always activate properly when I turned it on, and it wouldn't always deactivate properly when I turned it off. These patches fix issues with the clock enable/disable transitions.
With these patches applied, the driver works flawlessly with my use cases on the PXA168. I don't have any other PXAxxx devices to test with.
Changes in v3:
- Switch to abrupt shutdown mode instead of the delay hack from v2.
- Fix commit message explaining why duty cycle is set to 0.
- Add documentation link and limitations section at top of file.
Changes in v2:
- Remove pxa_pwm_enable and pxa_pwm_disable.
- Reorganize pxa_pwm_apply based on Uwe's suggestions.
- Enable this driver with ARCH_MMP for the PXA168.
- Add delay after clock is disabled (and inhibit brief on/off blips).
Doug Brown (6):
pwm: pxa: Remove pxa_pwm_enable/disable
pwm: pxa: Set duty cycle to 0 when disabling PWM
pwm: pxa: Remove clk enable/disable from pxa_pwm_config
pwm: pxa: Use abrupt shutdown mode
pwm: pxa: Add reference manual link and limitations
pwm: pxa: Enable for MMP platform
drivers/pwm/Kconfig | 2 +- drivers/pwm/pwm-pxa.c | 58 +++++++++++++++++++------------------------ 2 files changed, 26 insertions(+), 34 deletions(-)
Signature · 1 line
2.34.1