Skip to content

staging: r8188eu: some cleanups

Michael Straube linux-staging lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5staging: r8188eu: merge odm_types.h into other headersdrivers/staging/r8188eu/include/odm.h drivers/staging/r8188eu/include/odm_RTL8188E.h drivers/staging/r8188eu/include/odm_types.h +1 more+9 -180 replies
2/5staging: r8188eu: convert rtw_init_evt_priv() to common error logicdrivers/staging/r8188eu/core/rtw_cmd.c drivers/staging/r8188eu/include/rtw_cmd.h drivers/staging/r8188eu/os_dep/os_intfs.c+5 -70 replies
3/5staging: r8188eu: convert rtw_init_cmd_priv() to common error logicdrivers/staging/r8188eu/core/rtw_cmd.c drivers/staging/r8188eu/include/rtw_cmd.h drivers/staging/r8188eu/os_dep/os_intfs.c+6 -60 replies
4/5staging: r8188eu: convert rtw_init_mlme_priv() to common error logicdrivers/staging/r8188eu/core/rtw_mlme.c drivers/staging/r8188eu/os_dep/os_intfs.c+5 -90 replies
5/5staging: r8188eu: convert _rtw_init_sta_priv() to common error logicdrivers/staging/r8188eu/core/rtw_sta_mgt.c drivers/staging/r8188eu/include/sta_info.h drivers/staging/r8188eu/os_dep/os_intfs.c+5 -50 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by.

PatchPhilipp Hortmann
SeriesT-b
1/5
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] staging: r8188eu: some cleanups

The first patch of this series merges leftover macros in odm_types.h into appropriate other headers and removes odm_types.h.

The other patches convert some functions away from returning _FAIL / _SUCCESS.

Note: Converting _rtw_init_xmit_priv() and _rtw_init_recv_priv() away from _FAIL / _SUCCESS is a bit more complicated. I am going to do that in follow up patches.

Tested on x86_64 with Inter-Tech DMG-02.

Michael Straube (5):
staging: r8188eu: merge odm_types.h into other headers
staging: r8188eu: convert rtw_init_evt_priv() to common error logic
staging: r8188eu: convert rtw_init_cmd_priv() to common error logic
staging: r8188eu: convert rtw_init_mlme_priv() to common error logic
staging: r8188eu: convert _rtw_init_sta_priv() to common error logic

 drivers/staging/r8188eu/core/rtw_cmd.c         | 16 +++++++---------
 drivers/staging/r8188eu/core/rtw_mlme.c        | 12 ++++--------
 drivers/staging/r8188eu/core/rtw_sta_mgt.c     |  6 +++---
 drivers/staging/r8188eu/include/odm.h          |  3 ++-
 drivers/staging/r8188eu/include/odm_RTL8188E.h |  7 +++++++
 drivers/staging/r8188eu/include/odm_types.h    | 16 ----------------
 drivers/staging/r8188eu/include/rtl8188e_hal.h |  1 -
 drivers/staging/r8188eu/include/rtw_cmd.h      |  4 ++--
 drivers/staging/r8188eu/include/sta_info.h     |  2 +-
 drivers/staging/r8188eu/os_dep/os_intfs.c      |  8 ++++----
 10 files changed, 30 insertions(+), 45 deletions(-)
 delete mode 100644 drivers/staging/r8188eu/include/odm_types.h
Signature · 1 line
2.37.3