Skip to content

crypto: fix TLS PSK credentials on Windows platforms

Daniel P. Berrangé qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2crypto: check for and report errors setting PSK credentialscrypto/tlscredspsk.c+13 -32 replies
2/2tests: avoid DOS line endings in PSK filetests/unit/crypto-tls-psk-helpers.c+5 -62 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchBin MengPhilippe Mathieu-Daudé
1/2R-b T-b R-b
2/2R-b T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] crypto: fix TLS PSK credentials on Windows platforms

A mixup with DOS/UNIX line endings, combined with lack of error checking, resulted in us not initializing the PSK credentials on the client side.

Daniel P. Berrangé (2):
crypto: check for and report errors setting PSK credentials
tests: avoid DOS line endings in PSK file

 crypto/tlscredspsk.c                | 16 +++++++++++++---
 tests/unit/crypto-tls-psk-helpers.c | 11 +++++------
 2 files changed, 18 insertions(+), 9 deletions(-)
Signature · 1 line
2.37.3