Skip to content

mm/hugetlb: Fix selftest failures with write check

Peter Xu linux-mm lkml 3 versions – Applied

Status from this message: [merged mm-stable] mm-selftest-uffd-explain-the-write-missing-fault-check.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 0 repliesApplied 3/3
  2. v23 patches 8 repliesSuperseded
  3. v13 patches 7 repliesSuperseded

Changes in v3 from the cover letter

- Rebase to akpm mm-unstable

Patches in v3 All 3 applied

#Subject and filesSizeRepliesApplied
1/3mm/hugetlb: Fix race condition of uffd missing/minor handlingmm/hugetlb.c+52 -70 repliesApplied
2/3mm/hugetlb: Use hugetlb_pte_stable in migration race checkmm/hugetlb.c+3 -40 repliesApplied
3/3mm/selftest: uffd: Explain the write missing fault checktools/testing/selftests/vm/userfaultfd.c+21 -10 repliesApplied

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchMike KravetzDavid Hildenbrand
1/3R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] mm/hugetlb: Fix selftest failures with write check

v3:
- Rebase to akpm mm-unstable
v2:
- Fix the commit message of patch 1, replacing CoW with wr-unprotect example

Currently akpm mm-unstable fails with uffd hugetlb private mapping test randomly on a write check.

The initial bisection of that points to the recent pmd unshare series, but it turns out there's no direction relationship with the series but only some timing change caused the race to start trigger.

The race should be fixed in patch 1. Patch 2 is a trivial cleanup on the similar race with hugetlb migrations, patch 3 comment on the write check so when anyone read it again it'll be clear why it's there.

Thanks,

Peter Xu (3):
mm/hugetlb: Fix race condition of uffd missing/minor handling mm/hugetlb: Use hugetlb_pte_stable in migration race check mm/selftest: uffd: Explain the write missing fault check

 mm/hugetlb.c                             | 66 ++++++++++++++++++++----
 tools/testing/selftests/vm/userfaultfd.c | 22 +++++++-
 2 files changed, 76 insertions(+), 12 deletions(-)
Signature · 1 line
2.37.3